Page MenuHomePhabricator
Create Task
Maniphest T406974

Show message when no wishes found
Closed, ResolvedPublicBUG REPORT
Actions

Description

When no wishes are found in a wish index table, the pagination message reads "Showing results 1–0 of 0". Additionally, there is no indication that the empty table is a correct state.

Instead, the pagination should be hidden if there is no data, and a message added, such as No wishes found.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add empty-state message to WishIndexTablemediawiki/extensions/CommunityRequestsmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Samwilson created this task.Fri, Oct 10, 11:05 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptFri, Oct 10, 11:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Fri, Oct 10, 11:05 AM

Change #1195184 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Add empty-state message to WishIndexTable

https://gerrit.wikimedia.org/r/1195184

gerritbot added a project: Patch-For-Review.Fri, Oct 10, 11:05 AM
Samwilson updated the task description. (Show Details)Fri, Oct 10, 11:06 AM

The "Showing results 1–0 of 0" in the pagination is perhaps actually a bug in Codex.

Samwilson updated the task description. (Show Details)Fri, Oct 10, 11:09 AM
Samwilson edited projects, added Community-Tech (Sea Lion Squad); removed Community-Tech.Fri, Oct 10, 11:56 AM
gerritbot added a comment.Fri, Oct 10, 1:19 PM

Change #1195184 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Add empty-state message to WishIndexTable

https://gerrit.wikimedia.org/r/1195184

Samwilson mentioned this in rECOR8533b1c60ee3: Add empty-state message to WishIndexTable.Fri, Oct 10, 1:19 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Oct 10, 1:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Fri, Oct 10, 2:00 PM
MusikAnimal moved this task from Backlog to Entity index pages on the MediaWiki-extensions-CommunityRequests board.Sat, Oct 11, 5:49 PM
Samwilson claimed this task.Mon, Oct 13, 5:36 AM
Samwilson moved this task from Backlog - groomed to QA on the Community-Tech (Sea Lion Squad) board.
MusikAnimal changed the task status from Open to In Progress.Tue, Oct 14, 5:56 AM
MusikAnimal changed the task status from In Progress to Open.Tue, Oct 14, 6:57 AM
MusikAnimal triaged this task as Medium priority.Tue, Oct 14, 4:10 PM
dom_walden closed this task as Resolved.Fri, Oct 17, 2:34 PM
dom_walden subscribed.

I used an intercepting proxy to change the API response from beta to simulate having no wishes:

no_wishes_found.png (681×988 px, 79 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits