Page MenuHomePhabricator

Unclear why Z22284 is failing
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The test says it should be true, but it returns false instead, and therefor the test fails.

What should have happened instead?:
It should pass the test.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Same for https://www.wikifunctions.org/view/en/Z23875 / test for malade

Reported on chat on March 6 by Vigneron

Event Timeline

Fundamentally, the implementation assumes a shape for a Wikidata statement that is no longer valid (lacking a Z6003K7). I think the statements need to be filtered by property type (T382921 would be nice) and projected to their value to avoid locking in to a particular shape.

I created a hacky implementation to do this but it took me so long that I was unable to publish it (silent error), even though it produced the correct result for the connected tests and « malade ». It is pasted below for reference. Most of the clutter comes from emulating a degenerate Wikidata statement, which wouldn’t have been necessary if I had filtered just the values from the filtered statements. I’ll try to remember that if I get round to re-implementing it again later!

composition

same Wikidata item reference (value of Wikidata statement (first Object or default (filter by Key reference (filter statements by property type (statements from lexeme (Select Wikidata lexeme), Typed list (Wikidata property reference, grammatical gender)), Key reference ("Z6003K3"), Typed list (Object, feminine)), emulate Wikidata statement object (Typed list (Wikidata item reference), Typed list (Wikidata lexeme reference), Select Wikidata property, Typed list (Wikidata item reference, masculine), Typed list (Wikidata lexeme reference), Typed list (Object), normal, Typed list (Wikidata property claim), Typed list (Wikidata reference), value))), feminine)

Jdforrester-WMF assigned this task to GrounderUK.
Jdforrester-WMF subscribed.

Thank you! I've disconnected the old implementation and connected yours.