Page MenuHomePhabricator

VisualEditor accesskeys and publish buttons don’t work properly when using preview / review changes
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • go to https://en.wikipedia.org/wiki/User:Lucas_Werkmeister/sandbox (or any other sandbox of your choice)
  • edit source (2017 wikitext editor; I think I’ve also noticed the problems described here in properly “visual” VE but that’s not available on my sandbox page so “edit source” it is)
  • edit the wikitext
  • press Alt+Shift+S (or S with whatever the accesskey combination on your OS+browser is)
  • type an edit summary
  • press Alt+Shift+P (ditto) for preview
  • content with the edit, press Alt+Shift+S again to save it
    • nothing happens
  • move your hand to the mouse, move the pointer to the “publish changes” button all the way over in the corner, and click it
    • instead of publishing changes, it just leaves the preview and goes back to the main saving dialog
  • press Esc to leave the dialog
    • now you’re stuck and neither Alt+Shift+S nor clicking “publish changes…” will bring the saving dialog back
  • press F5 or otherwise reload the page to recover
  • press Alt+Shift+S (ditto) to open the saving dialog
  • type an edit summary
  • click “review your changes”
  • press Alt+Shift+S (ditto) or click “publish changes”
    • either will just return to the saving dialog rather than publishing the changes

What happens?:
(see above)

What should have happened instead?:
(also see above; the “Publish changes” button, when it doesn’t have a trailing ellipsis, should directly save the edit like it used to, and also the S accesskey should always work)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
This started happening one or two, possibly three weeks ago for me. I’m sorry I didn’t report it earlier – I assumed that it was disruptive enough that by the time I reported it, a fix would already have been merged and be ready to roll out with next week’s train, but I can’t find any Phabricator task for it yet?

Other information (browser name/version, screenshots, etc.):
Firefox Developer Edition (144) on Linux

Event Timeline

Interestingly, it's <accesskey>+P that breaks it. As soon as that has been used, it won't let the save accesskey work again. Previewing by just clicking the button works fine...