ShellBox tests override PHPUnit\Framework\TestCase::run(), marked as final in phpunit 10
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Oct 10 2025, 9:10 PM

Project Tags

Referenced Files

None

Subscribers

Description

When trying to update to phpunit 10 there is an error

Fatal error: Cannot override final method PHPUnit\Framework\TestCase::run() in tests\ClientServerTestCase.php on line 63

This seems similiar to T342259 and was also mention as part of T328919

Needs migration, maybe to the before(Class)/after(Class) hooks

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Release v4.5.0	mediawiki/libs/Shellbox	master	+40 -0
	Upgrading phpunit/phpunit (9.6.34 => 10.5.63)	mediawiki/libs/Shellbox	master	+257 -418

Mentioned In: T416064: Test Shellbox on PHP 8.5
Mentioned Here: T328919: Upgrade PHPUnit in MediaWiki code to PHPUnit 10
T342259: Move MediaWikiIntegrationTestCase setup and teardown away from run()

Change #1235427 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/Shellbox@master] Upgrading phpunit/phpunit (9.6.34 => 10.5.63)

Change #1235427 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] Upgrading phpunit/phpunit (9.6.34 => 10.5.63)

Jdforrester-WMF assigned this task to Reedy.

Change #1286347 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/libs/Shellbox@master] Release v4.5.0

Change #1286347 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] Release v4.5.0