Page MenuHomePhabricator

Unknown Configuration Option "gitlab.api_key" in Phab Local Config
Closed, ResolvedPublic

Description

See https://phabricator.wikimedia.org/config/issue/config.unknown.gitlab.api_key/

cf T324149 and especially T385480 mentioning gitlab_api_key, different spelling than gitlab.api_key (dot vs underscore), same in puppet's modules/profile/manifests/phabricator/main.pp.

Phab admins can see its current value in the table on https://phabricator.wikimedia.org/config/edit/gitlab.api_key/

Maybe that Phab local config value predates pulling a secret value from Hiera?
Not sure I interpret T385480 correctly thus CC'ing @brennen for potential input.

Event Timeline

Aklapper triaged this task as Low priority.
brennen claimed this task.
brennen added a project: User-brennen.

As I understand it: gitlab.api_key in the local.json created by each scap deployment is derived from the phabricator.local.gitlab_api_key set in puppet (from a lookup of profile::phabricator::main::gitlab_api_key) and written to /etc/phabricator/config.yaml.

In other words: This is the expected config value, although confusing and tangled for the usual reasons.