Page MenuHomePhabricator
Create Task
Maniphest T407113

Wikidata Vector 2022 sticky header covers sticky property name for properties with many values
Closed, ResolvedPublicBUG REPORT
Actions

Description

In Wikidata, property names on items stick to the top of their container, so when you scroll down, the property name is still visible when the list of statements for that property is long.

To reproduce:

What happens:

  • The property name is not visible, because it is sticky behind the sticky header

What should happen:

Before scroll, no problem:

image.png (1,181×512 px, 35 KB)

After scroll, property name covered:
image.png (1,138×390 px, 28 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Display sticky property labels below sticky headersJon Harald Søbymediawiki/extensions/Wikibasemaster+26 -0
Customize query in gerrit

Related Objects

Event Timeline

Bean49 created this task.Oct 13 2025, 12:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2025, 12:03 PM
Jakob_WMDE added a project: Wikidata-Omega.Oct 14 2025, 8:34 AM
jhsoby reopened this task as Open.Oct 16 2025, 8:03 AM
jhsoby closed this task as a duplicate of T406114: When opening a link to an anchor in Vector 2022, the target is partly hidden behind the sticky header.
jhsoby subscribed.

Sorry, I think I misunderstood the problem here. They're similar, but not the same.

jhsoby updated the task description. (Show Details)Oct 16 2025, 8:09 AM
gerritbot added a comment.Oct 17 2025, 10:07 AM

Change #1196876 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Wikibase@master] Display sticky property labels below sticky headers

https://gerrit.wikimedia.org/r/1196876

gerritbot added a project: Patch-For-Review.Oct 17 2025, 10:07 AM
jhsoby mentioned this in T407611: Add a design token for the height of skins' sticky headers.Oct 17 2025, 10:39 AM
• Lucas_Werkmeister_WMDE subscribed.Oct 17 2025, 3:34 PM

I don’t get the sticky header locally (despite being logged in – it looks similar but doesn’t behave sticky); do I need to do something to get it?

• Lucas_Werkmeister_WMDE added a comment.Oct 17 2025, 3:40 PM

Ah, stickyHeader.js has a hard-coded list of namespaces where sticky headers are enabled, and my wiki’s Item namespace isn’t one of them.

function isAllowedNamespace( namespaceNumber ) {
	// Corresponds to Main, User, Wikipedia, Template, Help, Category, Portal, Module.                                                                                                                                                                                                                                                                                                        
	const allowedNamespaceNumbers = [ 0, 2, 4, 10, 12, 14, 100, 828 ];
	// Also allow on all talk namespaces (compare NamespaceInfo::isTalk()).                                                                                                                                                                                                                                                                                                                   
	const isAllowedTalk = namespaceNumber > 0 && namespaceNumber % 2 !== 0;
	return isAllowedTalk || allowedNamespaceNumbers.includes( namespaceNumber );
}
• Lucas_Werkmeister_WMDE added a comment.Oct 17 2025, 3:47 PM

Leaving a code review comment here because I can’t attach images on Gerrit:

PS2 changed the top from calc( 3.125rem + 10px ); to just 3.125rem + 10px; – but I think the calc() is necessary after all. On PS2, I get an absurd amount of whitespace:

image.png (406×449 px, 12 KB)

And the dev tools say that it has top: 13.125rem; – so I guess Less just added the 10 to the 3.125rem ignoring the px unit. (Might be a Less.php-specific bug? But might also be “garbage in, garbage out” – as far as I’m aware 3.125rem + 10px isn’t valid CSS, so it wouldn’t really work better if Less hadn’t done the addition.)
With the calc(), it looks better:
image.png (409×309 px, 11 KB)

gerritbot added a comment.Oct 20 2025, 11:56 AM

Change #1196876 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Display sticky property labels below sticky headers

https://gerrit.wikimedia.org/r/1196876

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 20 2025, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2025, 12:30 PM
jhsoby claimed this task.Oct 20 2025, 12:33 PM

Thanks for the review, @Lucas_Werkmeister_WMDE! Should I just close this task now, or should we wait for deployment and/or testing?

• Lucas_Werkmeister_WMDE edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.Oct 20 2025, 12:41 PM
• Lucas_Werkmeister_WMDE moved this task from new to the board to Product Verification on the Wikidata-Omega (The Board) board.

Let’s put it into our product verification column :)

Arian_Bozorg closed this task as Resolved.Oct 20 2025, 2:01 PM
Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
Arian_Bozorg subscribed.

Looks good! Thank you so much

• Lucas_Werkmeister_WMDE edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).Nov 28 2025, 11:46 AM
karapayneWMDE moved this task from Newly completed tasks to 2025 Q4 on the Wikidata-Omega (Completed Tasks) board.Feb 10 2026, 5:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits