Is "not found at all" an advantage over "found last active version and told that it's unmaintained"?

In T407115#11273216, @Dzahn wrote:

Is "not found at all" an advantage over "found last active version and told that it's unmaintained"?

I think so. When we don't find it, we don't need to worry about making breaking changes to it. Every time, we want to make a change, we go and see "oh it's abandoned, never mind". It wastes devs time.

Gotcha! thanks for that example

The skin is not pulled in explicitly. It's pulled in because it's in https://raw.githubusercontent.com/MWStake/nonwmf-skins/master/.gitmodules I suggest creating a PR there and ours should be automatically reflected once it's merged.

In T407115#11275970, @Ladsgroup wrote:

The skin is not pulled in explicitly. It's pulled in because it's in https://raw.githubusercontent.com/MWStake/nonwmf-skins/master/.gitmodules I suggest creating a PR there and ours should be automatically reflected once it's merged.

FYI, there's been previous discussion in MWStake/nonwmf-extensions about the idea of removing archived exts from that repo specifically: https://github.com/MWStake/nonwmf-extensions/issues/73 (in particular, #issuecomment-2053894437 & #issuecomment-2053904588 might be relevant here).

(so I guess, maybe it might be better to auto-detect archived GitHub repos within Codesearch itself [T317989], than submit PRs to remove them from upstream nonwmf-(extensions|skins) when it's not currently clear that that should happen.)

The README in the MWStake repo says "If the skin is no longer supported and does not work with any supported version of MediaWiki, it should be removed. ". Since DarkVector's last update (at least according to it's MW skin page) was in November 2022, just before the release of 1.39 LTS (which is EOL this December), it presumably works with that version, but I'm not sure how to properly check for the newer supported versions.

In T407115#11276072, @jhsoby wrote:

The README in the MWStake repo says "If the skin is no longer supported and does not work with any supported version of MediaWiki, it should be removed. ".

Huh, okay; thanks for pointing that out. So I guess that might mean there's a potential difference in removal policy between nonwmf-extensions & nonwmf-skins (if I'm interpreting the comments in nonwmf-extensions#73 correctly)?
[cc @MarkAHershberger FYI/in case you're interested]

In T407115#11276072, @jhsoby wrote:

The README in the MWStake repo says "If the skin is no longer supported and does not work with any supported version of MediaWiki, it should be removed. ". Since DarkVector's last update (at least according to it's MW skin page) was in November 2022, just before the release of 1.39 LTS (which is EOL this December), it presumably works with that version, but I'm not sure how to properly check for the newer supported versions.

If that's the case, that repository seems long overdue for a substantial cleanout. There are numerous examples of code in there that haven't been touched since long before the COVID pandemic, which I've come across while removing deprecated functions. Granted, I've probably furthered the case for that by (further) breaking some of them...