Page MenuHomePhabricator
Create Task
Maniphest T407153

API-powered linting for wikitext using Parsoid
Closed, ResolvedPublic
Actions

Description

This task is about the wikitext portion of T394965: Provide API-powered linting of supported languages in CodeMirror. See parent task for details applicable to all modes/languages we plan to support.

The /transform/wikitext/to/lint REST API endpoint will allow us to provide real-time linting from Parsoid (i.e. the same results as MediaWiki-extensions-Linter). This can be ran in parallel with the existing JS worker.

Perhaps we could also provide initial linting results from our PHP, so that they are shown immediately once CodeMirror initializes. The /transform/wikitext/to/lint/{title}/{revision} endpoint could be used for that (since the user is not necessarily editing the latest revision).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CodeMirrorMediaWiki: lint using the REST APImediawiki/extensions/CodeMirrormaster+117 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

MusikAnimal created this task.Oct 13 2025, 6:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2025, 6:26 PM
MusikAnimal mentioned this in T407154: API-powered linting for JavaScript using Peast.Oct 13 2025, 6:38 PM
MusikAnimal mentioned this in T394965: Provide API-powered linting of supported languages in CodeMirror.Oct 13 2025, 6:46 PM
Escargot_rouge subscribed.Oct 13 2025, 7:26 PM
Bhsd moved this task from Backlog to Improvement on the MediaWiki-extensions-CodeMirror board.Oct 14 2025, 8:07 PM
gerritbot added a comment.Oct 16 2025, 8:57 AM

Change #1191795 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorMediaWiki: lint using the REST API

https://gerrit.wikimedia.org/r/1191795

gerritbot added a project: Patch-For-Review.Oct 16 2025, 8:57 AM
MusikAnimal changed the task status from Open to In Progress.Oct 22 2025, 7:17 PM
Bhsd mentioned this in T408623: CodeMirror linter does not warn on unclosed tags.Oct 29 2025, 12:07 AM
Bhsd added a subtask: T408623: CodeMirror linter does not warn on unclosed tags.Oct 29 2025, 4:41 AM
gerritbot added a comment.Oct 29 2025, 6:15 AM

Change #1191795 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorMediaWiki: lint using the REST API

https://gerrit.wikimedia.org/r/1191795

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2025, 6:31 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.1; 2025-11-05).Oct 29 2025, 7:00 AM
Bhsd added a comment.EditedOct 29 2025, 2:15 PM

Currently there are some duplicate rules between WikiLint and Parsoid, such as unclosed-quotes-in-heading (Parsoid)/format-leakage#apostrophe (WikiLint), duplicate-ids (Parsoid)/no-duplicate#id (WikiLint), bogus-image-options (Parsoid)/no-duplicate#imageParameter (WikiLint), fostered (Parsoid)/fostered-content (WikiLint), wikilink-in-extlink (Parsoid)/nested-link (WikiLint), and obsolete-tag (Parsoid)/obsolete-tag (WikiLint). However, the marked text range can be different between the two linters, usually more precise from WikiLint. What should we do with these rules?

MusikAnimal mentioned this in T408729: Add preferences to select between available linters in CodeMirror.Oct 29 2025, 6:16 PM

I think generally speaking Parsoid should take precedence, as it is the authority. In my testing it didn't seem too confusing to have both running side-by-side, especially after you added the "clickable lint tooltips", but I only tested so many things.

I think the next step is to add preferences for each linter. That will likely satisfy most user's concerns with respect to overlapping rules. I've filed T408729: Add preferences to select between available linters in CodeMirror for that.

Escargot_rouge mentioned this in T409490: Lint tooltips in CodeMirror sometimes make it complicated to edit.Thu, Nov 6, 8:52 PM
Bhsd closed this task as Resolved.Fri, Nov 7, 2:30 PM
Bhsd moved this task from Improvement to Done on the MediaWiki-extensions-CodeMirror board.
Bhsd closed subtask T408623: CodeMirror linter does not warn on unclosed tags as Resolved.Fri, Nov 7, 2:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits