Page MenuHomePhabricator
Create Task
Maniphest T407222

Increase maximum duration for IP auto-reveal to 3 months
Open, HighPublic
Actions

Description

Background

The IP auto-reveal feature lets certain trusted users enable a mode where temporary account IP addresses are displayed by default next to their name (in most places where the user name is displayed). This is to aid patrolling work once temporary accounts are rolled out.

Currently to enable the mode, the user clicks a tool link, then is asked to choose an expiry time (1 hour or 30 minutes), but we have heard feedback that this adds too much extra work for patrollers on wikis with a high volume of edits.

Increase the maximum duration to 3 months, and add an option for this in the auto-reveal dialog.

Acceptance criteria
  • The maximum allowed duration for IP auto-reveal is 3 months
  • The options to choose from in the dialog that appears when switching on auto-reveal are: 1 hour; 1 day; 3 months

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
IP auto-reveal: Wait for success before updating UI on state changemediawiki/extensions/CheckUsermaster+135 -43
IP auto-reveal: Ensure maximum expiry is respectedmediawiki/extensions/CheckUsermaster+21 -2
IP auto-reveal: Add longer expiry optionsmediawiki/extensions/CheckUsermaster+21 -11
IPAutoRevealOffDialog: Show maximum duration in error messagemediawiki/extensions/CheckUsermaster+37 -7
IP auto-reveal: Increase default maximum expiry to 3 monthsmediawiki/extensions/CheckUsermaster+1 -1
IP auto-reveal: Make maximum expiry time configurablemediawiki/extensions/CheckUsermaster+66 -16
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Tue, Oct 14, 12:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Oct 14, 12:58 PM
Tchanders mentioned this in T406722: Make seamless version of IP auto-reveal.Tue, Oct 14, 12:59 PM
gerritbot added a comment.Tue, Oct 14, 2:15 PM

Change #1195559 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Make maximum expiry time configurable

https://gerrit.wikimedia.org/r/1195559

gerritbot added a project: Patch-For-Review.Tue, Oct 14, 2:15 PM

Change #1195560 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Increase default maximum expiry to 3 months

https://gerrit.wikimedia.org/r/1195560

gerritbot added a comment.Tue, Oct 14, 2:26 PM

Change #1195645 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Add longer expiry options

https://gerrit.wikimedia.org/r/1195645

Tchanders moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Tue, Oct 14, 2:27 PM
Tchanders added a comment.Tue, Oct 14, 2:30 PM

Moving to code review for the first 2 patches, but I have a specification question too.

@KColeman-WMF How should we display the expiry time on the dialog that appears when switching off auto-reveal, now that it can be longer than 1 day? Here's how it currently appears:

image.png (297×559 px, 30 KB)

(meaning 89 days, 23 hours, etc)

Niharika moved this task from To triage to In progress on the Temporary accounts (Global wiki rollout) board.Tue, Oct 14, 3:07 PM
KColeman-WMF added a comment.Wed, Oct 15, 11:54 AM

@Tchanders I explored a few approaches for displaying the timer.

auto-reveal-timer-ux-14Oct.png (1×2 px, 111 KB)

The consensus on the team is to go for option 1:

Time remainingExample copy
Less than 1 day remaining0 days, 23:59:59
More than 1 day remaining89 days, 23:59:15
gerritbot added a comment.Wed, Oct 15, 5:06 PM

Change #1195559 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Make maximum expiry time configurable

https://gerrit.wikimedia.org/r/1195559

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Wed, Oct 15, 6:00 PM
gerritbot added a comment.Thu, Oct 16, 5:13 PM

Change #1195560 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Increase default maximum expiry to 3 months

https://gerrit.wikimedia.org/r/1195560

gerritbot added a comment.Thu, Oct 16, 5:44 PM

Change #1196728 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IPAutoRevealOffDialog: Show maximum duration in error message

https://gerrit.wikimedia.org/r/1196728

codenamenoreste subscribed.Fri, Oct 17, 4:35 AM
NguoiDungKhongDinhDanh subscribed.Fri, Oct 17, 1:45 PM

See also m:User:NguoiDungKhongDinhDanh/IPAutoReveal.js.

Novem_Linguae subscribed.Sat, Oct 18, 2:48 AM
Novem_Linguae awarded a token.Sat, Oct 18, 2:51 AM
gerritbot added a comment.Mon, Oct 20, 11:07 AM

Change #1196728 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IPAutoRevealOffDialog: Show maximum duration in error message

https://gerrit.wikimedia.org/r/1196728

gerritbot added a comment.Mon, Oct 20, 1:12 PM

Change #1195645 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Add longer expiry options

https://gerrit.wikimedia.org/r/1195645

Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 20, 1:31 PM
Tchanders triaged this task as High priority.Mon, Oct 20, 1:50 PM
Tchanders moved this task from Needs review to Needs QA on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)); removed Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)).Mon, Oct 20, 2:21 PM
OKryva-WMF moved this task from Backlog to Needs QA on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.
Titore subscribed.Tue, Oct 21, 9:19 AM
dom_walden added a comment.Thu, Oct 23, 1:55 PM

@Tchanders I am finding that occasionally the request to action=globalpreferences isn't being sent. I am not sure how to reproduce it reliably. I am seeing it locally and on testwiki.

Tchanders added a comment.Fri, Oct 24, 9:33 AM

Thanks @dom_walden . This is the same as the expiry issue found in T407257#11298877 - I'll push a fix.

gerritbot added a comment.Fri, Oct 24, 9:46 AM

Change #1198511 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Ensure maximum expiry is respected

https://gerrit.wikimedia.org/r/1198511

gerritbot added a project: Patch-For-Review.Fri, Oct 24, 9:46 AM
gerritbot added a comment.Fri, Oct 24, 10:35 AM

Change #1198511 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Ensure maximum expiry is respected

https://gerrit.wikimedia.org/r/1198511

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.25; 2025-10-28); removed MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Fri, Oct 24, 11:00 AM
gerritbot added a comment.Fri, Oct 24, 11:22 AM

Change #1198520 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Wait for success before updating UI on state change

https://gerrit.wikimedia.org/r/1198520

dom_walden added a comment.Fri, Oct 24, 1:58 PM

I don't know if this matters, but when opening the dialog with auto-reveal off, I see this warning in the console:

[Vue warn]: There is already an app instance mounted on the host container.
If you want to mount another app on the same host container, you need to unmount the previous app by calling `app.unmount()` first.

When opening with auto-reveal on, I see the above message and also:

[Vue warn]: Invalid prop: type check failed for prop "expiryTimestamp". Expected String with value "1769090193", got Number with value 1769090193.
STran added a comment.Mon, Oct 27, 11:15 AM

[Vue warn]: There is already an app instance mounted on the host container.

Per our convo, looks like this was already happening and isn't causing any problems.

[Vue warn]: Invalid prop: type check failed for prop "expiryTimestamp". Expected String with value "1769090193", got Number with value 1769090193.

Fixed with I20d370c2ecfdab69551b290ee9392b3bb9cbce0c

gerritbot added a comment.Mon, Oct 27, 3:53 PM

Change #1198520 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Wait for success before updating UI on state change

https://gerrit.wikimedia.org/r/1198520

Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 27, 4:32 PM
dom_walden moved this task from Needs QA to Done on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Tue, Oct 28, 10:30 AM

I have retested after patches T407222#11305681, T407222#11312565 and 1198554.

I have yet to see the bug in T407222#11303009.

The second warning message in T407222#11306241 no longer appears.

There are some bugs/improvements to the error handling, but nothing that I think should block the deployment (T408521, T408526, T408528 and T408539). There is also T408534.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits