Page MenuHomePhabricator
Create Task
Maniphest T407225

Missing @covers for AbstractBlock
Open, LowPublic
Actions

Description

I suspect AbstractBlock is actually better covered than https://doc.wikimedia.org/cover/mediawiki-core/includes/block/AbstractBlock.php.html suggests via CompositeBlock, DatabaseBlock or SystemBlock... Probably a missing @covers or two?

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: Add @covers for AbstractBlockReedymediawiki/coremaster+3 -0
Customize query in gerrit

Event Timeline

Reedy created this task.Oct 14 2025, 1:06 PM
Restricted Application added a project: Product Safety and Integrity. · View Herald TranscriptOct 14 2025, 1:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy triaged this task as Low priority.Oct 14 2025, 1:10 PM
gerritbot added a comment.Oct 14 2025, 1:13 PM

Change #1196065 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] tests: Add @covers for AbstractBlock

https://gerrit.wikimedia.org/r/1196065

gerritbot added a project: Patch-For-Review.Oct 14 2025, 1:13 PM
gerritbot added a comment.Oct 14 2025, 3:52 PM

Change #1196065 merged by jenkins-bot:

[mediawiki/core@master] tests: Add @covers for AbstractBlock

https://gerrit.wikimedia.org/r/1196065

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 14 2025, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 14 2025, 4:31 PM
OKryva-WMF moved this task from Inbox to Inbox on the Product Safety and Integrity board.Oct 24 2025, 3:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits