Page MenuHomePhabricator

[MEX][SPIKE] M4.1.10 - Musical notation statements on mobile
Closed, ResolvedPublic

Description

As an editor, i would like to be able to add musical notation statements.

Screenshot 2025-11-25 at 13.47.18.png (982×2 px, 223 KB)

Figma

EDIT

  • Once the property musical notation (apparently now renamed Lilypond Notation) is selected, the input field appears and becomes active - and we also show rank, add qualifier and add reference
  • in this case, error check only happens after publishing (UX debt for the future)
  • when there is something in the input field, the publish button becomes blue - as in desktop

Whatever the user entered, there is always a publish.

DISPLAY

if the user entered a correct lilypond notation

  • we show the musical notation, as on desktop
  • Nice To have: If there is horizontal overflow, do truncation with fade as suggested by codex, to suggest to the user that he can horizontally scroll (not implemented on desktop). If not possible then there is no overflow solution and it should simply cut off

If the notation is not correct

  • the sentence "Unable to compile Lylipond input file" displays in Gray500 with a error icon after
  • on tap on the error icon, a popover appears, the error icon shows, the popover title is "issues", useCloseButton is active, primary and secondary actions & useDefaultAction off.
  • the error box of lilypond shows as content, scrollable if it exceeds 330 height.

Related Objects

Event Timeline

karapayneWMDE renamed this task from Musical notation statements on mobile to [MEX] M4.1.1 - Musical notation statements on mobile.Oct 15 2025, 9:20 AM
Alice.moutinho updated the task description. (Show Details)

ticket is considered to meet our DOR and can be pulled into the backlog once M4 is started

Task time notes:

  • The icon / popover mechanism for errors will be the same as for constraint violations, see T400676
    • It probably makes sense to implement the “happy path” first and then have a separate task for errors once the code is ready for that
  • The “musical notation” data type lives in the Score extension, not in Wikibase
    • Do we need to introduce Cypress tests in Score?

Spike: investigate how it makes sense to split up and implement this task (timebox ca. 4 hours).

ArthurTaylor renamed this task from [MEX] M4.1.1 - Musical notation statements on mobile to [MEX][SPIKE] M4.1.1 - Musical notation statements on mobile.Dec 2 2025, 11:03 AM

spike notes:

  • when a snakvalue with musical notation datatype is added or edited, renderSnakValueHtml() seems to do the right thing. It returns html with an image, as expected. The styling fixes in T412128 are enough to cover existing, new, and edited musical notation values.

The task split looks pretty sensible, and we can go through in more detail when we do the task breakdown. The big concern I have is about the end-to-end testing - we would need a way to enable the Musical Notation datatype for Wikibase when the Score extension is loaded, and we would need there to be a live Shellbox for CI that has lilypond installed. I expect that both of these things will be hard to achieve with Quibble. We might have to make do with unit testing - still an improvement on the zero tests currently included in the Score extension.

Task split looks good to me as well! (And I’m also not sure if Cypress tests will be doable.)

makes sense! I'll add this context to T412141

Thanks to @AudreyPenven_WMDE for the wmcli / musical notations local integrations documentations effort.
Related docs: https://wiki.wikimedia.de/wiki/Benutzer:Audrey.Penven/mwcli_notes

karapayneWMDE renamed this task from [MEX][SPIKE] M4.1.1 - Musical notation statements on mobile to [MEX][SPIKE] M4.1.10 - Musical notation statements on mobile.Feb 10 2026, 4:27 PM