Page MenuHomePhabricator

[MEX] M4.1.1 - Func - Commons media statements on mobile
Closed, ResolvedPublic

Description

As an editor, i would like to be able to add commons media to statements

Screenshot 2026-01-06 at 11.25.45.png (766×2 px, 266 KB)

Figma File

A/C

  • Once a valid property for commons media is selected, the lookup appears and becomes active - the menu items have media thumbnails and labels
  • In the case of commons media, it is mandatory to pick something from the Lookup.
  • Because of this: inside the lookup, the menu should have the title option activated. Title: "Select an option".
  • Reuse the logic in T408928: [MEX] M3 - Create error handling for incorrectly filled and unfilled fields that are out of focus :
    • Should the user enter text in the field, and not make a selection of a picture and then leave the field with only text inside, activate error state
    • Should the user visit the field, and leave without making a selection: error state
  • If the user selects an image, the publish button becomes active.
  • Datatypes enabled
  • Tests!

The way images appear on the main statement page / display page has already been developed, i added it just for reference.

(!) Missing components names and error state visuals

Details

Related Changes in Gerrit:

Event Timeline

karapayneWMDE renamed this task from Commons media statements on mobile to [MEX] M4.1.1 - Commons media statements on mobile.Oct 15 2025, 9:20 AM

@Alice.moutinho Question for the UX: Why is the title option necessary if all the other lookups data type also require you to pickup something from the lookup?

Hi @mahmoud.abdelsattar.wmde, on the other lookups you have the option to type in the form as well. This is one of the few lookups where you mandatory need to pick an item that fits your description, and whatever you write is not "publishable". Hope this helps

But that’s true for other lookups as well? In an item lookup, even if you type in an item ID (of an item that exists), it’s not valid input until you select the item from the lookup:

image.png (189×433 px, 7 KB)

(On current desktop Wikidata, you can type direct input for commonsMedia values, but not for entity IDs, AFAICT.)

karapayneWMDE renamed this task from [MEX] M4.1.1 - Commons media statements on mobile to [MEX] M4.1.1 - Func - Commons media statements on mobile.Jan 6 2026, 9:48 AM
karapayneWMDE updated the task description. (Show Details)

@Alice.moutinho Are we still including the “Select an option:” text in the lookup? (I still don’t understand why it would be necessary.)

Change #1224116 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Add support for commonsMedia

https://gerrit.wikimedia.org/r/1224116

Change #1224726 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix error handling for non-entity lookup datatypes

https://gerrit.wikimedia.org/r/1224726

Assuming CI is happy, this should be ready for review.

ArthurTaylor renamed this task from [MEX] M4.1.1 - Func - Commons media statements on mobile to ar[MEX] M4.1.1 - Func - Commons media statements on mobile.Jan 9 2026, 12:34 PM
ArthurTaylor claimed this task.
ArthurTaylor renamed this task from ar[MEX] M4.1.1 - Func - Commons media statements on mobile to [MEX] M4.1.1 - Func - Commons media statements on mobile.Jan 9 2026, 12:35 PM

Change #1224116 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add support for commonsMedia

https://gerrit.wikimedia.org/r/1224116

Arian_Bozorg claimed this task.
Arian_Bozorg subscribed.

Looks good! Thanks so much