Background
The way the Editing functionality is implemented causes a number of issues. The current way is
- featuring an HTML standards compliance issue (div.reading-lists-selectable is nested as span child, which can cause render side-effects)
- causing issues with the line-clamping of the card titles as it's sometimes available, sometimes not leading to unnecessary duplication of code.
Goal
- Decide if full functionality or only UI is removed: As it only affects one API call, it seems better to remove it entirely
- Remove accordingly
Acceptance criteria
- Remove editing functionality
Requirement
Scope: ReadingLists extension (desktop + mobile).
- Remove all Reading List editing functionality and associated code from the UI and backend.
- This includes all components, buttons, and logic for editing or removing list entries.
- Remove or clean up the following:
- Editing mode toggle and toolbar.
- <edit-button> and <remove-button> in Entries.vue.
- EditButton and RemoveButton component files.
- Unused i18n messages related to editing or removing entries.
- Associated styles from styles.less.
- API endpoint deleteEntries in ext.readinglists.api.
- Verify that the Reading List page loads normally without errors when $wgReadingListsEnableSpecialPageToolbar = true.
- The Special:ReadingLists page must display only viewing functionality (no editing or removal UI).
BDD
Feature: Remove Reading List editing functionality
Scenario: Viewing Reading Lists after removal
Given I open Special:ReadingLists with `$wgReadingListsEnableSpecialPageToolbar = true`
When the page loads
Then there are no visible edit or remove buttons on Reading List cards
And no editing mode toggle is available
And the page displays normally without console or rendering errorsTest Steps
Test Case 1: Verify editing UI removal
- Open Special:ReadingLists on a wiki with $wgReadingListsEnableSpecialPageToolbar = true.
- Inspect the UI for list entries.
- AC1: No edit or remove buttons are visible on any Reading List cards.
- AC2: No “edit mode” toggle or toolbar is displayed.
- AC3: Layout and styling remain consistent with non-editable Reading List views.
https://phabricator.wikimedia.org/T407282#11321876
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T407282#11321876 |
| 2 | ✅ | T407282#11321876 |
| 3 | ✅ | T407282#11321876 |
