Page MenuHomePhabricator
Create Task
Maniphest T407300

Document options to GlobalRenameUser::rename
Closed, ResolvedPublic
Actions

Description

GlobalRenameUser::rename takes an $options array parameter but doesn't provide a single word of documentation on what options are accepted, what types they have, what they actually do, which ones are required, etc. Reading the entire call stack is not a viable approach, so these should be documented in the method doc comment.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Replace deprecated methods on User class in SpecialGlobalRenameUserD3r1ck01mediawiki/extensions/CentralAuthmaster+10 -4
GlobalRename: Add documentation for `GlobalRenameUser::rename()`D3r1ck01mediawiki/extensions/CentralAuthmaster+16 -0
Customize query in gerrit

Event Timeline

Daimona created this task.Oct 14 2025, 10:19 PM
Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptOct 14 2025, 10:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• DAlangi_WMF awarded a token.Oct 16 2025, 12:43 PM
gerritbot added a comment.Oct 16 2025, 12:43 PM

Change #1196677 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] GlobalRename: Add documentation for `GlobalRenameUser::rename()`

https://gerrit.wikimedia.org/r/1196677

gerritbot added a project: Patch-For-Review.Oct 16 2025, 12:43 PM
gerritbot added a comment.Oct 17 2025, 12:30 PM

Change #1196677 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalRename: Add documentation for `GlobalRenameUser::rename()`

https://gerrit.wikimedia.org/r/1196677

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2025, 12:30 PM
gerritbot added a comment.Oct 17 2025, 12:34 PM

Change #1196903 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] Special: Add more docs to `GlobalRenameUser::rename()`

https://gerrit.wikimedia.org/r/1196903

gerritbot added a project: Patch-For-Review.Oct 17 2025, 12:34 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 17 2025, 1:00 PM
gerritbot added a comment.Oct 20 2025, 1:57 PM

Change #1196903 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Replace deprecated methods on User class in SpecialGlobalRenameUser

https://gerrit.wikimedia.org/r/1196903

matmarex closed this task as Resolved.Oct 20 2025, 2:25 PM
matmarex assigned this task to • DAlangi_WMF.
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits