Another improvement to TextMatchEditCheck: allow individual rules (internally called matchItems) to specify their own case-sensitivity.
Description
Description
Details
Details
- Other Assignee
- Ryasmeen
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T360489 [EPIC] Generate and present edit suggestions at scale | |||
| Open | None | T404220 Suggestion engine: identify scalable ways to generate suggestions | |||
| Resolved | BUG REPORT | medelius | T398478 Improve TextMatchEditCheck | ||
| Resolved | medelius | T407301 Allow case sensitivity configuration for TextMatchEditCheck |
Event Timeline
Comment Actions
Change #1197373 had a related patch set uploaded (by Medelius; author: Medelius):
[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: Case sensitivity improvements
Comment Actions
Change #1197375 had a related patch set uploaded (by Medelius; author: Medelius):
[VisualEditor/VisualEditor@master] WIP: findText optimization for sets using Intl.Collator
Comment Actions
Change #1197376 had a related patch set uploaded (by Medelius; author: Medelius):
[VisualEditor/VisualEditor@master] Make findText’s set condition use locale for lowercasing.
Comment Actions
Change #1197376 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make findText’s set condition use locale for lowercasing.
Comment Actions
Change #1198410 had a related patch set uploaded (by Medelius; author: Medelius):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b70ee4a11)
Comment Actions
Change #1198410 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b70ee4a11)
Comment Actions
Change #1197373 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: Case sensitivity improvements
Comment Actions
QA: I’ve been keeping this doc updated with notes on TextMatch. The Testing/Demoing instructions section might be particularly helpful for you. Please let me know if you have any questions that aren’t covered there.
The code normalizes both map-based queries (words + replacements) and array-based queries at the start, so I don't anticipate any behavioral difference between the two. However, testing both types is probably a good idea.
Comment Actions
Change #1197375 abandoned by Medelius:
[VisualEditor/VisualEditor@master] WIP: findText optimization for sets using Intl.Collator
Reason:
No longer considering this solution.
Comment Actions
Thanks @medelius, for the detailed documentation with test instructions, it helped me a lot. I checked the case sensitivity configuration for both array-based and map-based queries. No issues found there.
I just wanted to confirm one thing, does invalidmode mean it will show only dismiss button as an action on the edit check dialog?
Comment Actions
I'm glad it helped.
Yes, that's correct. Any mode that's not one of the defined ones - "info", "delete", "replace" - will default to the dismiss action.