Page MenuHomePhabricator

VisualEditor find and replace highlighting persists after editing query
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Tol
Oct 15 2025, 7:47 AM
Referenced Files
F66793514: image.png
Oct 23 2025, 4:37 PM
F66751839: image.png
Oct 15 2025, 7:47 AM
F66751836: image.png
Oct 15 2025, 7:47 AM
F66751834: image.png
Oct 15 2025, 7:47 AM

Description

Steps to replicate the issue (include links if applicable):

  • Edit a page with VisualEditor
  • Open the find and replace dialogue (e.g. Ctrl+F, or hamburger menu ("page options") in VE top bar → "Find and replace")
  • Enter a "Find" query that is in fact present on the page, highlighting matches, of which one is initially selected
  • Edit the query (e.g. by adding or removing a character) to form a new query that is not present on the page

What happens?:

After editing the query to form a new non-present query, the match that was selected before editing remains highlighted.

What should have happened instead?:

As the new query no longer has any matches, it should no longer be highlighted.

Software version: Tested on English Wikipedia & Meta-Wiki (1.45.0-wmf.22).

Other information: Tested on Firefox 144.0b4 & Chrome 141.0.7390.76.

Screenshots:

After initial query:

image.png (130×829 px, 15 KB)

After editing:

image.png (130×829 px, 15 KB)

image.png (130×829 px, 15 KB)

Event Timeline

Also noting T199681 (not facially related, but also affecting VE find and replace highlighting).

Tol updated the task description. (Show Details)

Change #1196422 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] FindAndReplace: Clear focused highlight when there are no matches

https://gerrit.wikimedia.org/r/1196422

Change #1196422 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] FindAndReplace: Clear focused highlight when there are no matches

https://gerrit.wikimedia.org/r/1196422

Change #1196039 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (714b3ae07)

https://gerrit.wikimedia.org/r/1196039

Change #1196039 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (714b3ae07)

https://gerrit.wikimedia.org/r/1196039

Tested on en.wikipedia.org(one of the occurences wrongly alighted as shown in the attached screenshot) and en.wikipedia.beta(none alighted after editing the query - expected experience).

image.png (556×538 px, 52 KB)

EAkinloose edited projects, added Verified; removed Editing QA.

Works as expected