Page MenuHomePhabricator

hCaptcha: Allow to override the templates used for the save and captcha panels in the edit flow
Closed, ResolvedPublic0.25 Estimated Story Points

Description

Summary

  • MobileFrontend uses the API to edit
  • In order to support hCaptcha in the MobileFrontend, we need a mecanism in EditorOverlayBase that a allows extending classes (in this case SourceEditorOverlay) to provide a different content for the summary request and captcha panels
    • Because we need to change the default captcha code, and because hCaptcha should be included in the summary editor instead of in a dedicated step.

Acceptance criteria

  • The SourceEditor in the MobileFrontend has a mechanism to change the HTML for the summary and captcha steps

Event Timeline

hector.arroyo renamed this task from hCaptcha: Allow to override the templates used for te save and captcha panels in the edit flow to hCaptcha: Allow to override the templates used for the save and captcha panels in the edit flow.Wed, Oct 15, 11:25 AM
hector.arroyo set the point value for this task to 1.

Change #1196690 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/MobileFrontend@master] editor: Allow classes extending EditorOverlayBase to change panels' HTML

https://gerrit.wikimedia.org/r/1196690

Change #1198289 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/MobileFrontend@master] editor: Add hooks required for supporting hCaptcha on edits

https://gerrit.wikimedia.org/r/1198289

Change #1196690 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] editor: Allow classes extending EditorOverlayBase to change panels' HTML

https://gerrit.wikimedia.org/r/1196690

The patch for enabling the template overide #1196690 was merged, which is a technical prerrequisite for being able to support hCaptcha in the MobileFrontend.

Given its purely technical nature, this change is not manually testable on its own but as part of the parent task, so I'm closing this task bypassing QA.

hector.arroyo triaged this task as High priority.