Page MenuHomePhabricator
Create Task
Maniphest T407444

Use Html::* instead of Xml::* in CentralNotice
Closed, ResolvedPublic
Actions

Description

CentralNotice uses a bunch of Xml methods for building HTML rather than the (later) Html class, which was a bad idea at the time and now prohibited under policy. We're trying to kill off these methods except in situations where actual XML is needed (see parent), which means all code needs to be migrated.

Search:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace deprecated Xml::listDropdownmediawiki/extensions/CentralNoticemaster+15 -12
Replace deprecated Xml::optionmediawiki/extensions/CentralNoticemaster+71 -45
Replace deprecated Xml::fieldsetmediawiki/extensions/CentralNoticemaster+9 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Oct 15 2025, 10:13 PM
gerritbot added a comment.Jan 4 2026, 9:14 PM

Change #1222820 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Replace deprecated Xml::fieldset

https://gerrit.wikimedia.org/r/1222820

gerritbot added a project: Patch-For-Review.Jan 4 2026, 9:14 PM
gerritbot added a comment.Jan 5 2026, 9:58 AM

Change #1222820 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace deprecated Xml::fieldset

https://gerrit.wikimedia.org/r/1222820

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2026, 10:30 AM
gerritbot added a comment.Jan 5 2026, 7:53 PM

Change #1223255 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Replace deprecated Xml::option

https://gerrit.wikimedia.org/r/1223255

gerritbot added a project: Patch-For-Review.Jan 5 2026, 7:53 PM
Umherirrender subscribed.Jan 5 2026, 7:55 PM
In T341775#11485637, @gerritbot wrote:

Change #1221169 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace deprecated Xml::label

https://gerrit.wikimedia.org/r/1221169

Jdforrester-WMF added a comment.Mon, Jan 12, 1:52 PM

Looks like the two landed ones have been pulled into wmf_deploy in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1223689 but the third, just merging, isn't yet.

gerritbot added a comment.Mon, Jan 12, 2:11 PM

Change #1223255 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace deprecated Xml::option

https://gerrit.wikimedia.org/r/1223255

Maintenance_bot removed a project: Patch-For-Review.Mon, Jan 12, 2:31 PM
Ejegg subscribed.Fri, Jan 16, 6:10 PM

OK, I just merged the last one into wmf_deploy so it'll go out on next week's train.

Jdforrester-WMF added a comment.Fri, Jan 16, 8:29 PM
In T407444#11530057, @Ejegg wrote:

OK, I just merged the last one into wmf_deploy so it'll go out on next week's train.

Thank you! (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1227864 for those following along at home.)

Jdforrester-WMF closed this task as Resolved.Fri, Jan 16, 8:30 PM
Jdforrester-WMF assigned this task to Umherirrender.
Jdforrester-WMF added a project: MW-1.46-notes (1.46.0-wmf.12; 2026-01-20).
Umherirrender reopened this task as Open.Fri, Jan 16, 9:14 PM

Xml::listDropdown still needs replacing

Jdforrester-WMF added a comment.Fri, Jan 16, 9:27 PM
In T407444#11530544, @Umherirrender wrote:

Xml::listDropdown still needs replacing

Oops, yes.

gerritbot added a comment.Fri, Jan 30, 6:58 PM

Change #1235373 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Replace deprecated Xml::listDropdown

https://gerrit.wikimedia.org/r/1235373

gerritbot added a project: Patch-For-Review.Fri, Jan 30, 6:58 PM
gerritbot added a comment.Sun, Feb 1, 7:51 PM

Change #1235373 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace deprecated Xml::listDropdown

https://gerrit.wikimedia.org/r/1235373

Jdforrester-WMF closed this task as Resolved.Sun, Feb 1, 7:58 PM

OK, this is done in master, and will be done soon-enough on wmf-deploy. Let's call this Resolved.

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.14; 2026-02-03); removed MW-1.46-notes (1.46.0-wmf.12; 2026-01-20).Sun, Feb 1, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sun, Feb 1, 8:32 PM
Ejegg added a comment.Mon, Feb 2, 4:08 PM

Just merged it to wmf_deploy - it should go out this week!

Jdforrester-WMF added a comment.Mon, Feb 2, 4:42 PM
In T407444#11574429, @Ejegg wrote:

Just merged it to wmf_deploy - it should go out this week!

Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits