Page MenuHomePhabricator

Option for scrolling for readers while changing chapters
Closed, ResolvedPublic

Description

Requested by @Pigsonthewing on Github to add an option to be able to scroll instead of left/right swipe while moving to next chapter.

Note: While vertical scrolling is already there in the app, it does not scroll when moving to the next chapter, which requires left/right swipe in the current situation.

Task:

  • If scroll is enabled, show a sub option to called "Chapters" with two selection options. First option is "Up/Down" second is "Left/Right". By default Left/Right is selected and if Up/Down is selected, chapters should be switched by swiping up or down (at the end or start of the current chapter)
  • When Up/Down is enabled, then the existing left/right chapter navigation should be disabled and vice versa

Related task: T406912

Note:

  • T406893 has added a book completion percentage indicator bar, test and take care of while implementing scroll for continuous chapter.
  • Check that the feature for chapter jumps from the Contents tab at the top menu remains functional while implementing scroll for continuous chapter.

Event Timeline

Hi @Bodhisattwa and @Saiphani02, I'd love your guidance on if this works. I've set up the scroll behavior so:

  • When you reach the bottom and scroll further down, you move to the next chapter.
  • When you scroll back up to the previous chapter, it returns you to the last locator of the chapter.

I'm using each chapter's progression to identify if you have reached the end of the chapter and to identify the previous and next chapter to go to depending on if you are scrolling up or down.

Below shows how it works.

@Muguro As defined in description, this should be a new option which will be displayed if Scroll is enabled.

@Saiphani02 got it, that means we'll have two toggles for scroll and Continuous chapters?

Yes. Toggle for Scroll is already there. Continuous Chapters should be added for this.

Hi @Saiphani02, I have updated my PR and added the continous chapters toggle, please check it out.
https://github.com/cis-india/Wikisource-Reader/pull/54

Working perfectly. Thanks!