Page MenuHomePhabricator

Sub-ref design issues in the WikiEditor help panel
Open, Needs TriagePublic

Description

While demoing T399278 we found more small issues in the WikiEditor (2010) help panel.

  • The ref list is indented very deep, wasting space and making it appear misaligned.
  • Why do the examples need to contain a wiki link to begin with? The focus is on the ref syntax, not on links. Why not use a trivial plain text "book" as an example?
  • The subref example could be more meaningful as well, e.g. talk about a "page" number.
  • It looks like the subref number is displayed with a comma? That would be wrong.

Some of these are more a Regression because we changed a lot of the actual sub-ref code since we touched the help panel, but never came back and made the same changes to the help panel.

Event Timeline

Change #1195983 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix wrong comma in [2,1] in wikitext help panel

https://gerrit.wikimedia.org/r/1195983

Change #1195986 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix/simplify preview code in wikitext editor help panel

https://gerrit.wikimedia.org/r/1195986

Change #1196627 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Much simpler/real-world examples in wikitext help panel

https://gerrit.wikimedia.org/r/1196627

Change #1196627 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Much simpler/real-world examples in wikitext help panel

https://gerrit.wikimedia.org/r/1196627

Change #1195986 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix/simplify preview code in wikitext editor help panel

https://gerrit.wikimedia.org/r/1195986

Change #1195983 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix wrong comma in [2,1] in wikitext help panel

https://gerrit.wikimedia.org/r/1195983

Follow-up: The patch https://gerrit.wikimedia.org/r/1195986 made use of the CSS class mw-subreference-list. It appears like this is only loaded as part of the preview. When the user doesn't have the "Show preview when starting to edit" feature enabled the CSS is missing.

Change #1236244 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Load missing CSS for WikiEditor help panel

https://gerrit.wikimedia.org/r/1236244

Change #1236244 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Load missing CSS for WikiEditor help panel

https://gerrit.wikimedia.org/r/1236244