Page MenuHomePhabricator
Create Task
Maniphest T407473

Simplify sitelink site ID validation code
Closed, ResolvedPublic
Actions

Description

There is some duplication in multiple places of the code base (at least one in the CRUD domain and one in the reuse domain) using a combination of the SiteLinkGlobalIdentifiersProvider service with the siteLinkGroups setting to get the list of allowed site IDs.

Creating a service to just get all allowed site IDs would make the code simpler and reduce the number of dependencies of such validators.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Simplify SiteLinkTargetProviderJakobmediawiki/extensions/Wikibasemaster+53 -135
Simplify SiteLinkGlobalIdentifiersProviderJakobmediawiki/extensions/Wikibasemaster+34 -65
Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Oct 16 2025, 8:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2025, 8:38 AM
Jakob_WMDE updated the task description. (Show Details)Oct 16 2025, 8:38 AM
Jakob_WMDE claimed this task.Nov 10 2025, 1:04 PM
Jakob_WMDE moved this task from Tech backlog to Sprint 56 on the Wikibase Reuse Team board.
Jakob_WMDE edited projects, added: Wikibase Reuse Team (Sprint 56); removed: Wikibase Reuse Team.
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 56) board.
gerritbot added a comment.Nov 10 2025, 2:49 PM

Change #1203459 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Simplify SiteLinkGlobalIdentifiersProvider

https://gerrit.wikimedia.org/r/1203459

gerritbot added a project: Patch-For-Review.Nov 10 2025, 2:49 PM
gerritbot added a comment.Nov 10 2025, 3:36 PM

Change #1203471 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Simplify SiteLinkTargetProvider

https://gerrit.wikimedia.org/r/1203471

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 56) board.Nov 11 2025, 9:14 AM
WMDE-leszek edited projects, added: Wikibase Reuse Team (Sprint 57); removed: Wikibase Reuse Team (Sprint 56).Nov 11 2025, 9:55 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Reuse Team (Sprint 57) board.
gerritbot added a comment.Nov 14 2025, 11:29 AM

Change #1203459 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Simplify SiteLinkGlobalIdentifiersProvider

https://gerrit.wikimedia.org/r/1203459

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 14 2025, 12:01 PM
gerritbot added a comment.Nov 14 2025, 12:02 PM

Change #1203471 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Simplify SiteLinkTargetProvider

https://gerrit.wikimedia.org/r/1203471

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2025, 12:30 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 57) board.Nov 14 2025, 1:14 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Nov 25 2025, 9:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits