Page MenuHomePhabricator

Link to Special:BlockList in block notice box should use the narrowest IP as the wpTarget parameter
Closed, ResolvedPublic

Description

See https://test.wikipedia.org/wiki/Special:Contributions/255.255.255.255

  1. I have test-blocked 255.255.255.255 along with 255.255.255.254/31, so the box says This IP address is currently blocked 2 times (which is correct).
  2. Clicking View block list takes you to https://test.wikipedia.org/w/index.php?title=Special:BlockList&wpTarget=255.255.255.254%2F31 (where wpTarget is 255.255.255.254/31)
  3. Notice that the block for 255.255.255.255 isn't included in the list, despite the fact that the page is linked from the contributions page for 255.255.255.255.
  4. However, if you visit https://test.wikipedia.org/wiki/Special:BlockList?wpTarget=255.255.255.255, both blocks are shown.

So the fix would be to use 255.255.255.255 as wpTarget instead of 255.255.255.254/31. I've confirmed that this is a long-standing issue that predates T393902: Multiblocks: Display only active blocks on the top of blocked user's Special:Contributions page / when editing a blocked user's user [talk] page.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I can actually work on this but won't have the time until the weekend.

Change #1197009 had a related patch set uploaded (by Dragoniez; author: Dragoniez):

[mediawiki/core@master] Use input username as BlockList target in block notice

https://gerrit.wikimedia.org/r/1197009

Change #1197009 merged by jenkins-bot:

[mediawiki/core@master] Prioritize direct IP blocks in block notice box

https://gerrit.wikimedia.org/r/1197009