Page MenuHomePhabricator

Do not flag duplicate section headings as duplicate IDs
Closed, InvalidPublicFeature

Description

Feature summary (what you would like to be able to do and where):
Use a separate, low priority flag for duplicate section headings.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
There's no rule saying one can't have several sections named the same in an article, yet Linter flags these as duplicate IDs, which are themselves considered high priority. Duplicate section headings are typically harmless and completely intended. Consider an hypothetical article describing some random software:

Compatibility

Linux/Windows

blah

Other

blah

Requirements

Linux/Windows

foo

Other

bar

Right now this triggers several "high priority" errors, which does not make sense.

Benefits (why should this be implemented?):
Having a separate flag for this case ("duplicate-sections" ?) under the "low priority" category would give editors a cleaner list of problems which actually require attention, without the added noise.

Event Timeline

Can you give an example of where this is happening?

From the original commit where this lint was introduced we've tested

$desc = 'should not lint duplicate ids from headings';
$result = $this->wtToLint( "== Hi ho ==\n== Hi ho ==" );
$this->assertCount( 0, $result, $desc );

Maybe you're experiencing T393982 and that patch needs to be backported to the version you're using

Hi. Sorry, I didn't notice this until now as I didn't get any notification.

Yes, that seems correct as I can't reproduce the problem on mediawiki.org. Please feel free to close this ticket.

You should also have permissions to close this ticket yourself, just saying :) See https://www.mediawiki.org/wiki/Phabricator/Help#Receiving_updates_and_notifications for notifications