Page MenuHomePhabricator

[Regression] Temp accounts banner overlay blocks content on mobile
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
kostajh
Oct 16 2025, 6:59 PM
Referenced Files
F66758365: C2FAB7A4-23E8-42AA-843C-E9056E7A043D_1_105_c.jpeg
Oct 18 2025, 1:16 AM
F66758364: DA0036A9-3802-4992-95D7-4D36DE07D080_1_105_c.jpeg
Oct 18 2025, 1:16 AM
F66758363: D1D4A92A-B5B6-44C7-8EA1-82E611E71F58_1_105_c.jpeg
Oct 18 2025, 1:16 AM
F66758362: AB80490D-1C18-4B15-9424-E3D586546250_1_105_c.jpeg
Oct 18 2025, 1:16 AM
F66758361: 566B8315-6E47-48B4-905B-1EFABB45D89F_1_105_c.jpeg
Oct 18 2025, 1:16 AM
F66758360: AD320D4C-2436-4249-9240-70506F893D70_1_105_c.jpeg
Oct 18 2025, 1:16 AM
F66758359: CC6C0FC4-B06E-46A1-842D-38AB324BFB47_1_105_c.jpeg
Oct 18 2025, 1:16 AM
F66758358: 24BE5C0A-FA4D-4E61-9979-D40B57ED05FE_1_105_c.jpeg
Oct 18 2025, 1:16 AM

Description

Summary

The temporary accounts banner on mobile devices is behaving incorrectly when the source editor is opened, or when search results are shown:

image.png (858×412 px, 32 KB)

image.png (750×1,334 px, 392 KB)

Screenshot 2025-10-16 at 12.59.59 PM.png (428×672 px, 40 KB)

Requirement

Scope: Mobile web (Minerva skin).

  • The temporary accounts banner must not overlap or obscure any visible page elements on mobile.
  • This includes content, search results, and editing interfaces.
  • The banner must remain fixed and visible without blocking user interaction or viewable elements.

BDD

Feature: Prevent temp accounts banner from overlapping mobile content

  Scenario: Viewing any mobile interface
    Given I am using the Minerva skin on a mobile device
    When the temporary accounts banner is visible
    Then the banner does not overlap or obscure any page elements

Test Steps

Test Case 1: Verify banner placement on mobile

  1. Open Wikipedia on a mobile device (Minerva skin) as a temporary account user.
  2. Navigate through various pages, including search and edit modes.
  3. AC1: The temporary accounts banner does not overlap or obscure any page elements.

QA Results - Prod

ACStatusDetails
1T407549#11287143

Acceptance criteria

  • Temp accounts banner does not block view of page contents

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh triaged this task as High priority.Oct 16 2025, 7:25 PM
kostajh added a subscriber: Jdlrobson-WMF.

@Volker_E @Jdlrobson-WMF fixing this is fairly urgent, given that the banner is interfering with the source editor. Would you all be able to look at fixing this?

Change #1196748 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Temporary banner should not have such a high z-index in Minerva

https://gerrit.wikimedia.org/r/1196748

Change #1196760 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.45.0-wmf.23] Temporary user banner should not have such a high z-index

https://gerrit.wikimedia.org/r/1196760

Change #1196748 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Temporary user banner should not have such a high z-index

https://gerrit.wikimedia.org/r/1196748

Change #1196760 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.45.0-wmf.23] Temporary user banner should not have such a high z-index

https://gerrit.wikimedia.org/r/1196760

Mentioned in SAL (#wikimedia-operations) [2025-10-16T21:31:12Z] <jdlrobson@deploy2002> Started scap sync-world: Backport for [[gerrit:1196760|Temporary user banner should not have such a high z-index (T407549)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-16T21:35:36Z] <jdlrobson@deploy2002> jdlrobson: Backport for [[gerrit:1196760|Temporary user banner should not have such a high z-index (T407549)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-16T21:46:33Z] <jdlrobson@deploy2002> Finished scap sync-world: Backport for [[gerrit:1196760|Temporary user banner should not have such a high z-index (T407549)]] (duration: 15m 21s)

Jdlrobson-WMF renamed this task from Temp accounts banner overlay blocks content on mobile to [Regression] Temp accounts banner overlay blocks content on mobile.Oct 16 2025, 9:49 PM
Jdlrobson-WMF set the point value for this task to 1.

@Volker_E @Jdlrobson-WMF fixing this is fairly urgent, given that the banner is interfering with the source editor. Would you all be able to look at fixing this?

Thank you for your quick work on this!

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Tahoe 26.x
Browser: Chrome Canary (latest as of test date)
Device: iPhone 17 Pro Max

Test Case 1: Verify banner placement on mobile

  1. Open Wikipedia on a mobile device (Minerva skin) as a temporary account user.
  2. Navigate through various pages, including search and edit modes.
  3. AC1: The temporary accounts banner does not overlap or obscure any page elements.

24BE5C0A-FA4D-4E61-9979-D40B57ED05FE_1_105_c.jpeg (1,306×601 px, 82 KB)

CC6C0FC4-B06E-46A1-842D-38AB324BFB47_1_105_c.jpeg (601×1,306 px, 46 KB)

AD320D4C-2436-4249-9240-70506F893D70_1_105_c.jpeg (651×1,208 px, 82 KB)

566B8315-6E47-48B4-905B-1EFABB45D89F_1_105_c.jpeg (651×1,208 px, 97 KB)

AB80490D-1C18-4B15-9424-E3D586546250_1_105_c.jpeg (601×1,306 px, 106 KB)

D1D4A92A-B5B6-44C7-8EA1-82E611E71F58_1_105_c.jpeg (1,306×601 px, 117 KB)

DA0036A9-3802-4992-95D7-4D36DE07D080_1_105_c.jpeg (651×1,208 px, 154 KB)

C2FAB7A4-23E8-42AA-843C-E9056E7A043D_1_105_c.jpeg (1,306×601 px, 164 KB)

Edtadros added a project: Verified.
Edtadros updated the task description. (Show Details)
HFan-WMF claimed this task.