Page MenuHomePhabricator

Migrate editor code out of MobileFrontend into VisualEditor
Open, Needs TriagePublic

Description

Background

I assume it will be easier for all parties involved if all editor related code is in a single repository (perhaps VisualEditor?). This means very clear code boundaries and clearer contracts between teams.

Doing this will also allow us to evolve the editor code away from MobileFrontend's libraries towards OOUI and/or Codex.

User story

As a developer I want all editing code in one place.

Requirements

  • Move all editing code into mobile.init/editor.js (which in future will be the packageFile index file) https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1196766
  • We reduce MobileFrontend dependencies for editing code in mobile.init with non-MobileFrontend
  • util
  • IconButton, Icon
  • OverlayManager
  • (optional) we remove use of MobileFrontend Overlay for an OO.ui.Dialog
  • We pull out editing code from mobile.init module into mobile.editor.init
  • We add a new module to VisualEditor to replace mobile.editor.init and copy the new module across verbatim

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Change #1196766 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Move editor code to src/mobile.init/editor.js

https://gerrit.wikimedia.org/r/1196766

Change #1196767 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] WIP: Remove unnecessary MobileFrontend dependencies

https://gerrit.wikimedia.org/r/1196767

Change #1196768 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Remove OverlayManager from editor code in favor of router

https://gerrit.wikimedia.org/r/1196768

Change #1196766 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Move editor code to src/mobile.init/editor.js

https://gerrit.wikimedia.org/r/1196766

Change #1196768 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Remove OverlayManager from editor code in favor of router

https://gerrit.wikimedia.org/r/1196768