Page MenuHomePhabricator
Create Task
Maniphest T407643

Wikibase CI broken by removal of mTitle property from SearchResult base classes
Closed, ResolvedPublic
Actions

Description

Seen in this CI job:

There were 3 errors:

1) Wikibase\Lexeme\Search\Elastic\Tests\LexemeFulltextResultTest::testTransformResult with data set "by form id" ('fr', array('Q1', 'Q2', 'Q3'), array(array('L1', array('en', 'Q1'), 'Q2', array('duck', 'goose'), array(array('L1-F1', array('ducks', 'geese')), array('L1-F2', array('moreducks', 'moregeese'), array('Q3')))), array(array('L1-F2'))), array('L1', 'duck', 'Q1', 'en', 'Q2', 'L1-F2', 'moreducks', array(Wikibase\DataModel\Entity\ItemId Object (...)), 'moreducks', array('unit_test_fr_singular', 'duck', 'unit_test_fr_english')))
Undefined property: Wikibase\Lexeme\Search\Elastic\LexemeResult::$mTitle

/workspace/src/extensions/WikibaseLexemeCirrusSearch/src/LexemeResult.php:56
/workspace/src/extensions/WikibaseLexemeCirrusSearch/src/LexemeResultSet.php:71
/workspace/src/extensions/CirrusSearch/includes/Search/BaseCirrusSearchResultSet.php:136
/workspace/src/extensions/CirrusSearch/includes/Search/BaseCirrusSearchResultSet.php:242
/workspace/src/extensions/WikibaseLexemeCirrusSearch/tests/phpunit/LexemeFulltextResultTest.php:282

2) Wikibase\Lexeme\Search\Elastic\Tests\LexemeFulltextResultTest::testTransformResult with data set "by form repr" ('fr', array('Q1', 'Q2', 'Q4'), array(array('L1', array('en', 'Q1'), 'Q2', array('duck', 'goose'), array(array('L1-F1', array('ducks', 'geese'), array('Q4')), array('L1-F2', array('moreducks', 'moregeese'), array('Q3')))), array(array('ducks'))), array('L1', 'duck', 'Q1', 'en', 'Q2', 'L1-F1', 'ducks', array(Wikibase\DataModel\Entity\ItemId Object (...)), 'ducks', array('unit_test_fr_plural', 'duck', 'unit_test_fr_noun')))
Undefined property: Wikibase\Lexeme\Search\Elastic\LexemeResult::$mTitle

/workspace/src/extensions/WikibaseLexemeCirrusSearch/src/LexemeResult.php:56
/workspace/src/extensions/WikibaseLexemeCirrusSearch/src/LexemeResultSet.php:71
/workspace/src/extensions/CirrusSearch/includes/Search/BaseCirrusSearchResultSet.php:136
/workspace/src/extensions/CirrusSearch/includes/Search/BaseCirrusSearchResultSet.php:242
/workspace/src/extensions/WikibaseLexemeCirrusSearch/tests/phpunit/LexemeFulltextResultTest.php:282

3) Wikibase\Lexeme\Search\Elastic\Tests\LexemeFulltextResultTest::testTransformResult with data set "by another form repr" ('fr', array('Q1', 'Q2', 'Q3'), array(array('L1', array('en', 'Q1'), 'Q2', array('duck', 'goose'), array(array('L1-F1', array('ducks', 'geese'), array('Q4')), array('L1-F2', array('moreducks', 'moregeese'), array('Q3')))), array(array('moregeese'))), array('L1', 'duck', 'Q1', 'en', 'Q2', Wikibase\Lexeme\Domain\Model\FormId Object (...), 'moregeese', array(Wikibase\DataModel\Entity\ItemId Object (...)), 'moregeese', array('unit_test_fr_singular', 'duck', 'unit_test_fr_english')))
Undefined property: Wikibase\Lexeme\Search\Elastic\LexemeResult::$mTitle

/workspace/src/extensions/WikibaseLexemeCirrusSearch/src/LexemeResult.php:56
/workspace/src/extensions/WikibaseLexemeCirrusSearch/src/LexemeResultSet.php:71
/workspace/src/extensions/CirrusSearch/includes/Search/BaseCirrusSearchResultSet.php:136
/workspace/src/extensions/CirrusSearch/includes/Search/BaseCirrusSearchResultSet.php:242
/workspace/src/extensions/WikibaseLexemeCirrusSearch/tests/phpunit/LexemeFulltextResultTest.php:282

The property in question was just removed by search: Finish refactor of SearchResult; it was previously in RevisionSearchResultTrait AFAICT.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update LexemeResult for upstream refactoringLucas Werkmeister (WMDE)mediawiki/extensions/WikibaseLexemeCirrusSearchmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lucas_Werkmeister_WMDE created this task.Oct 17 2025, 4:31 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 17 2025, 4:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Lucas_Werkmeister_WMDE added a comment.Oct 17 2025, 4:31 PM

Marking this as a train blocker for next week because I think it would also break in production, not just in CI.

• Lucas_Werkmeister_WMDE added a parent task: T405680: 1.45.0-wmf.24 deployment blockers.Oct 17 2025, 4:32 PM
dcausse subscribed.Oct 17 2025, 4:32 PM
gerritbot added a comment.Oct 17 2025, 4:34 PM

Change #1196944 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update LexemeResult for upstream refactoring

https://gerrit.wikimedia.org/r/1196944

gerritbot added a project: Patch-For-Review.Oct 17 2025, 4:34 PM
dcausse added a comment.Oct 17 2025, 4:35 PM

I suspect that:

			// This copies FormTitleStoreLookup, we could instantiate one instead
			// but that would add a lot of wrapper code.
			if ( $this->mTitle !== null ) {
				$this->mTitle->setFragment( '#' . $result['formId'] );
			}

never quite worked, cirrussearch does not initialize mTitle, it sets title tho... looking into it

gerritbot added a comment.Oct 17 2025, 5:15 PM

Change #1196944 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update LexemeResult for upstream refactoring

https://gerrit.wikimedia.org/r/1196944

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2025, 5:30 PM
• Lucas_Werkmeister_WMDE mentioned this in rEWLCf28b8ff3a848: Update LexemeResult for upstream refactoring.Oct 17 2025, 5:44 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 17 2025, 6:00 PM
• Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 20 2025, 9:11 AM
• Lucas_Werkmeister_WMDE claimed this task.
• Lucas_Werkmeister_WMDE added a project: Wikidata-Omega (Completed Tasks).

PHPUnit CI seems to be fixed, closing.

Gehel edited projects, added: Discovery-Search (2025.09.26 - 2025.10.17); removed: Discovery-Search.Oct 20 2025, 2:37 PM
Gehel moved this task from Incoming to Done on the Discovery-Search (2025.09.26 - 2025.10.17) board.
Gehel moved this task from Done to Reported on the Discovery-Search (2025.09.26 - 2025.10.17) board.Oct 24 2025, 9:37 AM
karapayneWMDE moved this task from Newly completed tasks to 2025 Q4 on the Wikidata-Omega (Completed Tasks) board.Nov 24 2025, 6:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits