Page MenuHomePhabricator

Launch wikiminute video in modal, not new window
Closed, ResolvedPublic

Description

On the donor portal, launch the wikiminute video in a modal overlay on the Donor Portal not in a new popup window

Event Timeline

Change #1196948 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] WIP clicking thumbnail launches wikiminute video

https://gerrit.wikimedia.org/r/1196948

Change #1196948 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Clicking thumbnail launches wikiminute video

https://gerrit.wikimedia.org/r/1196948

This is deployed. Note no player controls, but maybe not needed as it's only a minute.

Thank you @Ejegg - tested on Firefox and Chrome - the modal pops up, but nothing plays for me:

image.png (1×1 px, 391 KB)

Interesting @AKanji-WMF - can you see any errors in the browser console?

Ah, never mind @AKanji-WMF, I see them now - it's a content security policy issue. I'll try adding the videos directly to the donor portal.

Change #1208358 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Host video directly on donorportal

https://gerrit.wikimedia.org/r/1208358

Change #1208363 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Add attribution link for video

https://gerrit.wikimedia.org/r/1208363

Change #1208358 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] CSS and click changes for video

https://gerrit.wikimedia.org/r/1208358

Change #1208363 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add attribution link for video

https://gerrit.wikimedia.org/r/1208363

Change #1208481 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Reuse the popup modal for wikiminute

https://gerrit.wikimedia.org/r/1208481

Confirming this works for me now! TY @Ejegg, CC: @KHill-WMF

Change #1208481 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Reuse the popup modal for wikiminute

https://gerrit.wikimedia.org/r/1208481

XenoRyet set Final Story Points to 2.