Page MenuHomePhabricator

PF_ComboBoxInput str_replace deprecation warning
Closed, ResolvedPublicBUG REPORT

Description

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in extensions/PageForms/includes/forminputs/PF_ComboBoxInput.php on line 103

With a form definition such as:

{{{for template| widget }}}

Combobox:
{{{field |scale |input type=combobox }}}

{{{end template}}}

Event Timeline

Change #1197005 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/PageForms@master] PFComboBoxInput: Fix null warning for autocomplete settings

https://gerrit.wikimedia.org/r/1197005

Change #1197005 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] PFComboBoxInput: Fix null warning for autocomplete settings

https://gerrit.wikimedia.org/r/1197005

Samwilson claimed this task.
Samwilson added a subscriber: Paladox.

Thanks @Paladox!