Page MenuHomePhabricator

EditCheck doesn't detect a sfn template and shows message about absent source
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open any article with enabled Reference Check
  • Add a passage at least 50 characters long with the sfn template (I assume it could also affect other similar templates)
  • Try to save a page

What happens?:
EditCheck displays a message stating that the passage lacks citations.

What should have happened instead?:
It shouldn't display any message and should instead show a dialog with a brief description of the edit.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

photo_2025-10-21_12-52-34.jpg (1,707×342 px, 112 KB)

Event Timeline

ppelberg subscribed.

Per offline discussion, we're going to explore this for another ~1 hour and then make a call about whether we'll continue with it.

I have some prior art for finding whether templates contain references: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1187849

It’s stalled on the thought that T404608 is better, and/or persuading Parsoid to explicitly specify that the data-mw attributes will not be stripped from template internals. (Otherwise the approach could break somewhat randomly with parsoid changes that are technically "non-breaking" per their spec.)

Change #1229181 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] ReferenceCheck: accept sfn template as valid reference

https://gerrit.wikimedia.org/r/1229181

Test wiki on Patch demo by CMedelius-WMF using patch(es) linked to this task was deleted:

https://20a2d0fa1e.catalyst.wmcloud.org/w/

Change #1229181 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ReferenceCheck: accept sfn template as valid reference

https://gerrit.wikimedia.org/r/1229181

ppelberg added a subscriber: dchan.

@dchan + @medelius: it looks like y'all found a path forward here. nicely done.

Ryasmeen edited projects, added: Verified; removed: Editing QA.