Page MenuHomePhabricator

Update Schema Events
Closed, ResolvedPublic5 Estimated Story Points

Description

Schema Events
Repository: https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/tree/master/jsonschema/analytics/product_metrics

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Update Test Kitchen product_metrics schemasrepos/data-engineering/schemas-event-secondary!106cjmingT407901/update-product-metrics-schemasmaster
Revert "Merge branch 'T407901/rename-product-metrics-fragments' into 'master'"repos/data-engineering/schemas-event-secondary!105cjmingrevert-914a8af4master
Revert "Merge branch 'T407901/rename-product-metrics' into 'master'"repos/data-engineering/schemas-event-secondary!104cjmingrevert-005bc79bmaster
Update product_metrics schema fragments to test_kitchenrepos/data-engineering/schemas-event-secondary!103cjmingT407901/rename-product-metrics-fragmentsmaster
Customize query in GitLab

Event Timeline

Sfaci updated the task description. (Show Details)

just verifying something here - do we want to replace product_metrics with test_kitchen in the secondary repo?
or do we want to have a subdirectory called test_kitchen within product_metrics?

i'm going to err on the former so someone let me know if it's actually the latter...

and does this task involve updating fragments too?
i.e. https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/tree/master/jsonschema/fragment/analytics/product_metrics?ref_type=heads
replace product_metrics in the directory structure with test_kitchen?

cc @JVanderhoop-WMF @Milimetric @KReid-WMF

just verifying something here - do we want to replace product_metrics with test_kitchen in the secondary repo?
or do we want to have a subdirectory called test_kitchen within product_metrics?

I would say both are the same thing, right? The name of the schema is based on the directory structure (or vice versa). That replacement would imply to rename the corresponding subdirectory, so I would say what you decided to do is the right thing

and does this task involve updating fragments too?
i.e. https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/tree/master/jsonschema/fragment/analytics/product_metrics?ref_type=heads
replace product_metrics in the directory structure with test_kitchen?

cc @JVanderhoop-WMF @Milimetric @KReid-WMF

According to the same criterion above, I would say we should rename also the fragments (schemas + subdirectories)

cjming set the point value for this task to 5.Dec 17 2025, 11:06 PM

Change #1223726 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/TestKitchen@master] Revert to `product_metrics` schemas

https://gerrit.wikimedia.org/r/1223726

Per discussion in Slack and https://wikitech.wikimedia.org/wiki/User:Ottomata/Organized_Code#Avoid_casual_names, we are declining this ticket and keeping Test Kitchen schemas with its current naming convention product_metrics

updated docs to include reasoning behind naming convention - https://wikitech.wikimedia.org/wiki/Test_Kitchen/Schemas#Base_schemas

i will keep this ticket open until all the reverts are merged then move to done (or declined?)

Per discussion in Slack and https://wikitech.wikimedia.org/wiki/User:Ottomata/Organized_Code#Avoid_casual_names, we are declining this ticket and keeping Test Kitchen schemas with its current naming convention product_metrics

updated docs to include reasoning behind naming convention - https://wikitech.wikimedia.org/wiki/Test_Kitchen/Schemas#Base_schemas

i will keep this ticket open until all the reverts are merged then move to done (or declined?)

We could also transform this ticket into something that reflect the work we are going to do, right? New 2.0.0 version, default value for coordinator as a replacement for xlab, the comments where Experimentation Lab, xlab and others are mentioned, and the removal of experiments fragment. After all there are some schema work that needs to be done. Is not what we planned at the beginning but that work is somehow related to the renaming

We could also transform this ticket into something that reflect the work we are going to do, right? New 2.0.0 version, default value for coordinator as a replacement for xlab, the comments where Experimentation Lab, xlab and others are mentioned, and the removal of experiments fragment. After all there are some schema work that needs to be done. Is not what we planned at the beginning but that work is somehow related to the renaming

good point - ok repurposing ticket accordingly

cjming renamed this task from Rename Schema Events to Update Schema Events.Jan 9 2026, 6:35 PM
cjming updated the task description. (Show Details)

Change #1223726 merged by jenkins-bot:

[mediawiki/extensions/TestKitchen@master] Revert to `product_metrics` schemas and use `default` as the coordinator value

https://gerrit.wikimedia.org/r/1223726

Change #1225675 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/TestKitchen@wmf/1.46.0-wmf.10] Revert to `product_metrics` schemas and use `default` as the coordinator value

https://gerrit.wikimedia.org/r/1225675

Change #1225675 abandoned by Clare Ming:

[mediawiki/extensions/TestKitchen@wmf/1.46.0-wmf.10] Revert to `product_metrics` schemas and use `default` as the coordinator value

Reason:

wrong revert

https://gerrit.wikimedia.org/r/1225675

Change #1225675 restored by Clare Ming:

[mediawiki/extensions/TestKitchen@wmf/1.46.0-wmf.10] Revert to `product_metrics` schemas and use `default` as the coordinator value

https://gerrit.wikimedia.org/r/1225675

Change #1225675 merged by jenkins-bot:

[mediawiki/extensions/TestKitchen@wmf/1.46.0-wmf.10] Revert to `product_metrics` schemas and use `default` as the coordinator value

https://gerrit.wikimedia.org/r/1225675

Mentioned in SAL (#wikimedia-operations) [2026-01-12T23:14:36Z] <cjming@deploy2002> Started scap sync-world: Backport for [[gerrit:1225675|Revert to product_metrics schemas and use default as the coordinator value (T407901)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-12T23:16:26Z] <cjming@deploy2002> cjming: Backport for [[gerrit:1225675|Revert to product_metrics schemas and use default as the coordinator value (T407901)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-01-12T23:20:49Z] <cjming@deploy2002> Finished scap sync-world: Backport for [[gerrit:1225675|Revert to product_metrics schemas and use default as the coordinator value (T407901)]] (duration: 06m 13s)