Page MenuHomePhabricator
Create Task
Maniphest T407903

refactor fetch logic
Closed, ResolvedPublic
Actions

Description

There's a lot of nesting happening inside of the wikilambda fetching code in fetchObject.js, from this MR
we have separated out some of the logic by way of helper functions but we can add in some early returns and clean this up a bit more.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2026-07-07-185549 to 2026-07-14-211423Jforresteroperations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade orchestrator from 2026-03-31-162258 to 2026-04-07-234729Jforresteroperations/deployment-chartsmaster+1 -1
Customize query in gerrit

Event Timeline

ecarg created this task.Oct 21 2025, 8:00 PM
ecarg triaged this task as Medium priority.Oct 21 2025, 10:29 PM
cmassaro moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.Oct 22 2025, 5:34 PM
gerritbot added a comment.Apr 8 2026, 1:59 PM

Change #1268967 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-03-31-162258 to 2026-04-07-234729

https://gerrit.wikimedia.org/r/1268967

gerritbot added a project: Patch-For-Review.Apr 8 2026, 1:59 PM
Jdforrester-WMF changed the task status from Open to In Progress.Apr 8 2026, 2:10 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (26Q4 (Apr–Jun)); removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.
Jdforrester-WMF changed the task status from In Progress to Open.Apr 8 2026, 2:12 PM
Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team; removed: Abstract Wikipedia team (26Q4 (Apr–Jun)), Patch-For-Review.
Jdforrester-WMF subscribed.
gerritbot added a comment.Apr 8 2026, 2:15 PM

Change #1268967 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-03-31-162258 to 2026-04-07-234729

https://gerrit.wikimedia.org/r/1268967

Jdforrester-WMF changed the task status from Open to In Progress.Jul 10 2026, 12:39 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (27Q1 (Jul–Sep)); removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.
CodeReviewBot added a project: Patch-For-Review.Jul 10 2026, 12:47 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/742

orchestrator: Flatten batched wikilambda_fetch error handling

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.Jul 11 2026, 1:03 PM
CodeReviewBot added a comment.Jul 11 2026, 1:03 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/742

orchestrator: Flatten batched wikilambda_fetch error handling

gerritbot added a comment.Jul 15 2026, 1:56 PM

Change #1311056 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-07-07-185549 to 2026-07-14-211423

https://gerrit.wikimedia.org/r/1311056

gerritbot added a comment.Jul 15 2026, 2:14 PM

Change #1311056 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-07-07-185549 to 2026-07-14-211423

https://gerrit.wikimedia.org/r/1311056

Jdforrester-WMF closed this task as Resolved.Jul 15 2026, 2:28 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits