Page MenuHomePhabricator

AbuseFilter 'showcaptcha' consequence is broken
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Create a test abuse filter with the 'showcaptcha' consequence enabled
  • Trigger that filter

What happens?:

  • No CAPTCHA is being shown.

What should have happened instead?:

  • A CAPTCHA should've been shown.

Examples::

Event Timeline

Dreamy_Jazz subscribed.

I've confirmed this myself. No captcha was shown.

Change #1198028 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ConfirmEdit@master] CaptchaConsequence: Re-use existing SimpleCaptcha instance

https://gerrit.wikimedia.org/r/1198028

Change #1198038 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/AbuseFilter@master] ConfirmEditHandler: Set CaptchaTrigger to 'edit'

https://gerrit.wikimedia.org/r/1198038

Change #1198058 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/AbuseFilter@master] ConfirmEditHandlerTest: Re-apply test

https://gerrit.wikimedia.org/r/1198058

Change #1198038 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] ConfirmEditHandler: Set CaptchaTrigger to 'edit' or 'create'

https://gerrit.wikimedia.org/r/1198038

Change #1198028 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] CaptchaConsequence: Re-use existing SimpleCaptcha instance

https://gerrit.wikimedia.org/r/1198028

@kostajh Should this be working on testwiki? I tried it and, although it is being logged, I don't actually see any captcha challenges.

EDIT: nevermind, I just noticed my user has skipcaptcha right.

I was able to create a new page in the Talk namespace (new users cannot create main pages on enwiki beta). Apparently I triggered the AF rule, but I did not actually see the captcha. My user did not have skipcaptcha.

I was able to create a new page in the Talk namespace (new users cannot create main pages on enwiki beta). Apparently I triggered the AF rule, but I did not actually see the captcha. My user did not have skipcaptcha.

I don't know about beta cluster, but it works fine on test.wikidata.org with this filter https://test.wikidata.org/wiki/Special:AbuseFilter/30

I was able to create a new page in the Talk namespace (new users cannot create main pages on enwiki beta). Apparently I triggered the AF rule, but I did not actually see the captcha. My user did not have skipcaptcha.

I don't know about beta cluster, but it works fine on test.wikidata.org with this filter https://test.wikidata.org/wiki/Special:AbuseFilter/30

I have seen various cases on testwiki and testwikidata where I don't see a captcha when creating a new page in other namespaces. I do see the captcha when editing those same pages after I have created them.

Change #1198058 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] ConfirmEditHandlerTest: Re-apply test

https://gerrit.wikimedia.org/r/1198058

I also don't see a captcha when I trigger a filter during the move, delete or upload actions. I had to test these locally because non-autoconfirmed users cannot normally do these actions.

I was prevented from doing an edit via ContentTranslation, but I was not shown a captcha to fill in, I just saw an error Unsupported captcha type encountered.

contenttranslation.png (448×1 px, 50 KB)

But, this might be an existing issue.