Page MenuHomePhabricator
Create Task
Maniphest T407937

TableFixups is missing tablecell-splitting support for several cases
Closed, ResolvedPublic
Actions

Description

Visualdiff testing revealed several tablefixup edge cases which all seem to effectively be missing functionality in TableFixups to process table cells which have swallowed table-cell markup and which need to be split up.

The following pages are examples seen so far - they are not all of which are fixable with a single patch, but are somewhat related.

  1. https://da.wikipedia.org/w/index.php?title=Skabelon:Convinfobox/testcases&oldid=12143257&useparsoid=1
  2. https://www.mediawiki.org/w/index.php?title=User:SSastry_(WMF)/Sandbox&oldid=7930921&useparsoid=1 (reproduced from a kowiki page)
  3. https://cs.wikipedia.org/wiki/Biatlon_na_Zimn%C3%ADch_olympijsk%C3%BDch_hr%C3%A1ch_2014_%E2%80%93_kvalifikace?useparsoid=1#Po%C5%99ad%C3%AD_zem%C3%AD
  4. https://tr.wikipedia.org/wiki/Serdal_Adal%C4%B1?useparsoid=1#S%C3%BCper_Lig_Performans%C4%B1

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump wikimedia/parsoid to 0.23.0-a5Subramanya Sastrymediawiki/vendormaster+432 -627
TableFixups: Fix getReparseTypeSubramanya Sastrymediawiki/services/parsoidmaster+50 -24
Bump wikimedia/parsoid to 0.22.0-a29Arlolramediawiki/vendormaster+444 -351
TableFixups: Generalize cell-splitting supportSubramanya Sastrymediawiki/services/parsoidmaster+80 -27
WIP: Split cells need reparsing even if they are not templatedSubramanya Sastrymediawiki/services/parsoidmaster+9 -2
Customize query in gerrit

Event Timeline

ssastry created this task.Oct 22 2025, 4:38 AM
Restricted Application added subscribers: revi, Aklapper. · View Herald TranscriptOct 22 2025, 4:38 AM
ssastry claimed this task.Oct 22 2025, 4:38 AM
ssastry edited projects, added: Content-Platform-Team (Work In Progress); removed: Content-Platform-Team.

Of the four cases, the first three are relatively easy to fix. The fourth one might end up being a wontfix -- to be investigated more.

gerritbot added a comment.Oct 22 2025, 4:39 AM

Change #1197377 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TableFixups: Generalize cell-splitting support

https://gerrit.wikimedia.org/r/1197377

gerritbot added a project: Patch-For-Review.Oct 22 2025, 4:39 AM

Change #1197741 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: TableFixups: Fix buggy getReparseType

https://gerrit.wikimedia.org/r/1197741

ssastry added a comment.EditedOct 22 2025, 4:40 AM

#1 & #2 are fixed by the first two patches. #3 is mostly fixed by the above patches, but not entirely. To be investigated.

ssastry moved this task from Backlog to In Progress on the Content-Platform-Team (Work In Progress) board.Oct 22 2025, 4:41 AM
ssastry added a project: OKR-Work.
ssastry renamed this task from TableFixups is missing table-splitting support for several cases to TableFixups is missing tablecell-splitting support for several cases.Oct 22 2025, 4:44 AM
ssastry updated the task description. (Show Details)
ssastry updated the task description. (Show Details)
gerritbot added a comment.Oct 22 2025, 3:20 PM

Change #1198097 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: Split cells need reparsing even if they are not templated

https://gerrit.wikimedia.org/r/1198097

gerritbot added a comment.Oct 22 2025, 7:32 PM

Change #1198097 abandoned by Subramanya Sastry:

[mediawiki/services/parsoid@master] WIP: Split cells need reparsing even if they are not templated

Reason:

squashed into parent patch

https://gerrit.wikimedia.org/r/1198097

gerritbot added a comment.Oct 23 2025, 9:58 PM

Change #1197377 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TableFixups: Generalize cell-splitting support

https://gerrit.wikimedia.org/r/1197377

gerritbot added a comment.Oct 27 2025, 6:29 PM

Change #1199040 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a29

https://gerrit.wikimedia.org/r/1199040

gerritbot added a comment.Oct 27 2025, 9:38 PM

Change #1199040 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a29

https://gerrit.wikimedia.org/r/1199040

cscott moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Nov 6 2025, 3:38 PM
MSantos moved this task from Uncategorized to Small Size Wikipedias on the Parsoid-Read-Views board.Nov 13 2025, 3:38 PM
MSantos edited projects, added: Parsoid-Read-Views (Small Size Wikipedias); removed: Parsoid-Read-Views.
gerritbot added a comment.Nov 14 2025, 2:03 AM

Change #1197741 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TableFixups: Fix getReparseType

https://gerrit.wikimedia.org/r/1197741

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2025, 2:30 AM
MSantos moved this task from In Progress to To Deploy on the Content-Platform-Team (Work In Progress) board.Nov 17 2025, 4:24 PM
gerritbot added a comment.Nov 17 2025, 7:06 PM

Change #1206434 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a5

https://gerrit.wikimedia.org/r/1206434

gerritbot added a project: Patch-For-Review.Nov 17 2025, 7:06 PM
gerritbot added a comment.Nov 17 2025, 8:06 PM

Change #1206434 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a5

https://gerrit.wikimedia.org/r/1206434

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2025, 8:31 PM
ssastry closed this task as Resolved.Nov 20 2025, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits