Page MenuHomePhabricator
Create Task
Maniphest T407961

<span> visible in translations where the title has not been translated
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The main heading says "<span lang="en" dir="ltr" class="mw-content-ltr">Blocking of fake signatures --[[User:Testuser|resutseT]]</span> (Community Wishlist/W121/ja)".

What should have happened instead?:
It says "Blocking of fake signatures --[[User:Testuser|resutseT]] (Community Wishlist/W121/ja)".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Escape wikitext syntax in wikitext storage, but keep it everywhere elsemediawiki/extensions/CommunityRequestsmaster+145 -47
parser: Add an option to Sanitizer::removeSomeTags() to allow commentsmediawiki/coremaster+53 -3
Ensure titles are sanitized for display and storagemediawiki/extensions/CommunityRequestsmaster+160 -10
Fix display of page title when title contains parser-produced HTMLmediawiki/extensions/CommunityRequestsmaster+6 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nardog created this task.Oct 22 2025, 9:52 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptOct 22 2025, 9:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Adarsh2406 subscribed.Oct 22 2025, 12:21 PM
gerritbot added a comment.Oct 22 2025, 1:23 PM

Change #1198059 had a related patch set uploaded (by Adarsh2406; author: Adarsh2406):

[mediawiki/extensions/CommunityRequests@master] Fix display of page title when title contains parser-produced HTML

https://gerrit.wikimedia.org/r/1198059

gerritbot added a project: Patch-For-Review.Oct 22 2025, 1:23 PM
Adarsh2406 added a comment.Oct 22 2025, 2:11 PM

Hey tried to fix this error can someone review my changes ?

Aklapper added a comment.Oct 22 2025, 5:14 PM

@Adarsh2406 Thanks for the patch! Please avoid pinging, there was already a patch notification right above your comment. Thanks.

Nardog added a comment.Oct 23 2025, 8:18 AM

<span> should also be removed from API responses.

https://meta.wikimedia.org/wiki/Special:ApiSandbox#action=query&format=json&list=communityrequests-wishes&formatversion=2&crwlang=ja&crwprop=title&crwlimit=max

MusikAnimal mentioned this in T406998: Translate language wrapping and CommunityRequests title extracting don't play nice together.Oct 23 2025, 8:41 PM
MusikAnimal merged a task: T406998: Translate language wrapping and CommunityRequests title extracting don't play nice together.
MusikAnimal moved this task from Backlog to Translation on the MediaWiki-extensions-CommunityRequests board.
MusikAnimal mentioned this in T407004: MinT translation does not translate the entity title nor status.
MusikAnimal added a parent task: T407004: MinT translation does not translate the entity title nor status.
MusikAnimal added subscribers: Pppery, MusikAnimal.
MusikAnimal triaged this task as Medium priority.Oct 23 2025, 8:43 PM
MusikAnimal added a comment.EditedOct 23 2025, 10:37 PM

<span> should also be removed from API responses.

https://meta.wikimedia.org/wiki/Special:ApiSandbox#action=query&format=json&list=communityrequests-wishes&formatversion=2&crwlang=ja&crwprop=title&crwlimit=max

Indeed! I've merged the above patch to get things moving along. The issue with the API is technically a separate issue, but nonetheless needs to be fixed. It would appear we are storing the Translate-provided markup, so I would think the fix should be there. r1198059 should still work as written because we aren't pulling the title from the API when viewing wish pages.

Related: T407000: Wikitext badly escaped on wishes page

MusikAnimal merged a task: T407000: Wikitext badly escaped on wishes page.Oct 23 2025, 10:39 PM
MusikAnimal added a subscriber: Vishnu_mishra.
gerritbot added a comment.Oct 23 2025, 10:46 PM

Change #1198059 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Fix display of page title when title contains parser-produced HTML

https://gerrit.wikimedia.org/r/1198059

jenkins-bot mentioned this in rECOR11a937032dd3: Fix display of page title when title contains parser-produced HTML.Oct 23 2025, 10:46 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.25; 2025-10-28).Oct 23 2025, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 23 2025, 11:30 PM
Adarsh2406 claimed this task.Oct 24 2025, 5:34 AM
Adarsh2406 added a project: RoadToWiki.
Adarsh2406 moved this task from Incoming to Completed on the RoadToWiki board.
gerritbot added a comment.Nov 3 2025, 2:53 AM

Change #1200744 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CommunityRequests@master] Ensure titles are HTML-safe for display, and sanitized in storage

https://gerrit.wikimedia.org/r/1200744

gerritbot added a project: Patch-For-Review.Nov 3 2025, 2:53 AM
MusikAnimal changed the task status from Open to In Progress.Nov 3 2025, 8:14 PM
MusikAnimal raised the priority of this task from Medium to High.
MusikAnimal edited projects, added Community-Tech (Sea Lion Squad); removed Community-Tech.
MusikAnimal moved this task from Backlog - groomed to In Development on the Community-Tech (Sea Lion Squad) board.
MusikAnimal added a comment.Nov 3 2025, 10:08 PM

Apologies for the noise with the reverting and re-reverting. Adarsh2406's work is great (thank you!), but it looks like there's more to be done.

MusikAnimal moved this task from In Development to Feedback and Review on the Community-Tech (Sea Lion Squad) board.Nov 3 2025, 10:08 PM
gerritbot added a comment.Nov 10 2025, 10:35 AM

Change #1200744 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Ensure titles are sanitized for display and storage

https://gerrit.wikimedia.org/r/1200744

jenkins-bot mentioned this in rECOR5d7c24de8e98: Ensure titles are sanitized for display and storage.Nov 10 2025, 10:35 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 10 2025, 11:32 AM
gerritbot added a comment.Nov 11 2025, 8:24 AM

Change #1203758 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CommunityRequests@master] Escape wikitext syntax in wikitext storage, but keep it everywhere else

https://gerrit.wikimedia.org/r/1203758

gerritbot added a project: Patch-For-Review.Nov 11 2025, 8:24 AM
gerritbot added a comment.Mon, Nov 17, 1:32 AM

Change #1206055 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] parser: Add an option to Sanitizer::removeSomeTags() to allow comments

https://gerrit.wikimedia.org/r/1206055

gerritbot added a comment.Tue, Nov 18, 12:33 AM

Change #1206055 merged by jenkins-bot:

[mediawiki/core@master] parser: Add an option to Sanitizer::removeSomeTags() to allow comments

https://gerrit.wikimedia.org/r/1206055

gerritbot added a comment.Sun, Nov 23, 11:13 PM

Change #1203758 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Escape wikitext syntax in wikitext storage, but keep it everywhere else

https://gerrit.wikimedia.org/r/1203758

jenkins-bot mentioned this in rECOR336821bd554f: Escape wikitext syntax in wikitext storage, but keep it everywhere else.Sun, Nov 23, 11:18 PM
Maintenance_bot removed a project: Patch-For-Review.Sun, Nov 23, 11:30 PM
MusikAnimal closed this task as Resolved.Mon, Nov 24, 4:40 PM
MusikAnimal mentioned this in T407000: Wikitext badly escaped on wishes page.Tue, Nov 25, 2:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits