Page MenuHomePhabricator
Create Task
Maniphest T408087

Make it clear that the mwbot replacement do not follow redirects
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In T401673 there's an ask if we could make the API calls to follow redirects. I digged into the current code and there's kind of a bug there right now. We don't specify that we will follow or not follow redirects, so by default we will follow redirect. However when fetch gets a redirect for a POST, it will switch to GET and drop the body (=our call will fail). See https://fetch.spec.whatwg.org/#http-redirect-fetch

AC:

  • Make sure our code do not try to follow redirects because redirects do not work for us

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
selenium: Make it clear that the API calls do not follow redirectsmediawiki/coremaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Peter created this task.Oct 23 2025, 10:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2025, 10:05 AM
Peter added a parent task: T405079: Stop using mwbot in Selenium tests.Oct 23 2025, 10:06 AM
gerritbot added a comment.Oct 23 2025, 10:08 AM

Change #1198297 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Make it clear that the API calls do not follow redirects

https://gerrit.wikimedia.org/r/1198297

gerritbot added a project: Patch-For-Review.Oct 23 2025, 10:08 AM
zeljkofilipin added a project: User-zeljkofilipin.Oct 24 2025, 9:58 AM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
Peter moved this task from Backlog to Ready to Refine on the Test Platform board.Oct 31 2025, 6:49 AM
zeljkofilipin removed a project: User-zeljkofilipin.Nov 5 2025, 11:07 AM
Peter added a project: Browser Test Platform.Nov 18 2025, 9:44 AM
Peter set the point value for this task to 1.Nov 20 2025, 11:45 AM
Peter moved this task from Ready to Refine to Refined (Discussed and Estimated) Backlog on the Test Platform board.
zeljkofilipin moved this task from Backlog to Prioritized on the Browser Test Platform board.Nov 20 2025, 2:42 PM
zeljkofilipin edited projects, added Test Platform (Taormina Three 18); removed Test Platform.Nov 24 2025, 10:26 AM
zeljkofilipin moved this task from Prioritized to Doing on the Browser Test Platform board.
zeljkofilipin moved this task from Backlog to Done on the Test Platform (Taormina Three 18) board.
gerritbot added a comment.Nov 24 2025, 1:02 PM

Change #1198297 merged by jenkins-bot:

[mediawiki/core@master] selenium: Make it clear that the API calls do not follow redirects

https://gerrit.wikimedia.org/r/1198297

Maintenance_bot removed a project: Patch-For-Review.Nov 24 2025, 1:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 24 2025, 2:00 PM
AMarkossyan-WMF closed this task as Resolved.Nov 24 2025, 4:38 PM
AMarkossyan-WMF claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits