Page MenuHomePhabricator
Create Task
Maniphest T408196

Migrate handlers of AutopromoteCondition hook to the new UserRequirementsCondition hook and deprecate the old one
Closed, ResolvedPublic
Actions

Description

In T408184: Replace AutopromoteCondition hook with a more general one, which supports non-performer users and remote users a new hook was created, which is a replacement for AutopromoteCondition. Currently both hooks are called and the legacy one is soft-deprecated, because there are still three known handlers of it:

These three extensions should be updated to handle UserRequirementsCondition instead.

Acceptance criteria

  • Codesearch lists no implementations of AutopromoteConditionHook
  • AutopromoteCondition is hard-deprecated

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix not allowing an external/non-performing user to meet `APCOND_TOR`Tchandersmediawiki/extensions/TorBlockmaster+7 -6
Hard-deprecate AutopromoteCondition hookMszwarcmediawiki/coremaster+3 -42
Use UserRequirementsCondition hook instead of AutopromoteConditionMszwarcmediawiki/extensions/FlaggedRevsmaster+45 -17
Do not allow an external/non-performing user to meet `APCOND_TOR`Tchandersmediawiki/extensions/TorBlockmaster+6 -0
Use UserRequirementsCondition hook instead of AutopromoteConditionMszwarcmediawiki/extensions/CentralAuthmaster+40 -20
Use UserRequirementsCondition hook instead of AutopromoteConditionMszwarcmediawiki/extensions/TorBlockmaster+12 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

mszwarc created this task.Oct 24 2025, 12:32 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptOct 24 2025, 12:32 PM
mszwarc moved this task from Inbox to Next sprint on the Product Safety and Integrity board.Oct 24 2025, 12:32 PM
mszwarc added a project: Essential-Work.
mszwarc added a subtask: T408184: Replace AutopromoteCondition hook with a more general one, which supports non-performer users and remote users.
Tchanders edited projects, added: Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)); removed: Product Safety and Integrity.Nov 5 2025, 11:52 AM

Brought into the current sprint as the next thing we can start working on, if there's time before the next sprint.

OKryva-WMF moved this task from Backlog to Ready on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Nov 5 2025, 12:55 PM
mszwarc closed subtask T408184: Replace AutopromoteCondition hook with a more general one, which supports non-performer users and remote users as Resolved.Nov 6 2025, 11:32 AM
gerritbot added a comment.Nov 7 2025, 9:00 AM

Change #1202979 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Use UserRequirementsCondition hook instead of AutopromoteCondition

https://gerrit.wikimedia.org/r/1202979

gerritbot added a project: Patch-For-Review.Nov 7 2025, 9:00 AM
mszwarc claimed this task.Nov 7 2025, 9:57 AM
mszwarc moved this task from Ready to In progress on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.
Tchanders edited projects, added: Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)); removed: Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)).Nov 10 2025, 11:51 AM
Tchanders moved this task from Backlog to In progress on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.
OKryva-WMF edited projects, added: OKR-Work; removed: Essential-Work.Nov 10 2025, 2:29 PM
gerritbot added a comment.Nov 12 2025, 8:59 AM

Change #1204248 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/TorBlock@master] Use UserRequirementsCondition hook instead of AutopromoteCondition

https://gerrit.wikimedia.org/r/1204248

gerritbot added a comment.Nov 12 2025, 9:36 AM

Change #1204248 merged by jenkins-bot:

[mediawiki/extensions/TorBlock@master] Use UserRequirementsCondition hook instead of AutopromoteCondition

https://gerrit.wikimedia.org/r/1204248

gerritbot added a comment.Nov 12 2025, 9:38 AM

Change #1202979 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Use UserRequirementsCondition hook instead of AutopromoteCondition

https://gerrit.wikimedia.org/r/1202979

gerritbot added a comment.Nov 12 2025, 9:42 AM

Change #1204255 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/FlaggedRevs@master] Use UserRequirementsCondtion hook instead of AutopromoteCondition

https://gerrit.wikimedia.org/r/1204255

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 12 2025, 10:01 AM
gerritbot added a comment.Nov 12 2025, 10:07 AM

Change #1204261 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] Hard-deprecate AutopromoteCondition hook

https://gerrit.wikimedia.org/r/1204261

mszwarc moved this task from In progress to Needs review on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 12 2025, 10:18 AM
Tacsipacsi subscribed.Nov 12 2025, 2:59 PM
gerritbot added a comment.Nov 13 2025, 12:02 PM

Change #1204835 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/TorBlock@master] Do not autopromote an external or non-performing user using `APCOND_TOR`

https://gerrit.wikimedia.org/r/1204835

gerritbot added a comment.Nov 13 2025, 3:21 PM

Change #1204835 merged by jenkins-bot:

[mediawiki/extensions/TorBlock@master] Do not allow an external/non-performing user to meet `APCOND_TOR`

https://gerrit.wikimedia.org/r/1204835

gerritbot added a comment.Nov 14 2025, 9:47 AM

Change #1205088 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/TorBlock@master] Fix not allowing an external/non-performing user to meet `APCOND_TOR`

https://gerrit.wikimedia.org/r/1205088

gerritbot added a comment.Nov 14 2025, 11:15 AM

Change #1205088 merged by jenkins-bot:

[mediawiki/extensions/TorBlock@master] Fix not allowing an external/non-performing user to meet `APCOND_TOR`

https://gerrit.wikimedia.org/r/1205088

gerritbot added a comment.Nov 14 2025, 1:53 PM

Change #1204255 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use UserRequirementsCondition hook instead of AutopromoteCondition

https://gerrit.wikimedia.org/r/1204255

gerritbot added a comment.Nov 14 2025, 2:18 PM

Change #1204261 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate AutopromoteCondition hook

https://gerrit.wikimedia.org/r/1204261

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2025, 2:30 PM
mszwarc closed this task as Resolved.Nov 14 2025, 2:44 PM
mszwarc updated the task description. (Show Details)
mszwarc moved this task from Needs review to Done on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits