All cookbooks have ownership so we should probably narrow down the list of the ones that we want to tackle. Are your concerns mostly for reimage, or other cookbooks?

I think all cookbooks should be in-scope, but let's start with reimage and any cookbooks that it might include. I think that should have the biggest impact.

Thanks again for taking a look. If I can do anything to help, let me know.

@bking as stated above, I/F owns only a subset of the available cookbooks, so a task to our team should focus on those ones. I am happy to work on any cookbook that you have in mind that may give some productivity boost to other SREs, but starting a full review of all cookbooks without a specific goal/reason/benefit seems overkill to me. We can try to review reimage and see how it goes, would it work?

Sure! That works for me. Thanks again for taking the time.

I'm in the middle of reimaging some hosts in T410681 , here's some quick notes on prompts that can be eliminated (in my opinion)

==> ATTENTION: Destructive action for relforge1008. Proceed?

I think this is supposed to protect users from reimaging the wrong host. Maybe a force flag to override this would be better? Not a huge deal either way if y'all want to keep it.

Puppet 7 auto-selected on >= Bookworm
==> Unless the host's role has been already migrated to Puppet 7,
Type "go" to proceed or "abort" to interrupt the execution

^^ this should be able to go

sre.puppet.sync-netbox-hiera

^^ More notes on why I believe this can be removed here , feel free to read through/disagree/offer feedback in the doc.

Change #1214488 had a related patch set uploaded (by Elukey; author: Elukey):

[operations/cookbooks@master] sre.hosts.reimage: remove puppet 5 support and default to 7

https://gerrit.wikimedia.org/r/1214488

Change #1214488 merged by jenkins-bot:

[operations/cookbooks@master] sre.hosts.reimage: remove puppet 5 support and default to 7

https://gerrit.wikimedia.org/r/1214488