Page MenuHomePhabricator
Create Task
Maniphest T408229

Bookmark icon is showing for browsers that do not support it
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
LMora-WMF
Authored By
Jdlrobson-WMF
Oct 24 2025, 4:25 PM
Project Tags
Referenced Files
F99400782: Screenshot 2026-08-21 at 12.31.16 PM.png
Fri, Aug 21, 4:50 PM
F99400761: Screenshot 2026-08-21 at 12.26.57 PM.png
Fri, Aug 21, 4:50 PM
F99401019: Screenshot 2026-08-21 at 12.46.16 PM.png
Fri, Aug 21, 4:50 PM
F99400642: Screenshot 2026-08-21 at 12.28.37 PM.png
Fri, Aug 21, 4:50 PM
F66987845: Screenshot 2025-10-24 at 9.24.30 AM.png
Oct 24 2025, 4:25 PM
Subscribers
Aklapper
aude
Etonkovidova
HFan-WMF
Jdlrobson-WMF
LMora-WMF
Volker_E

Description

Steps to replicate the issue (include links if applicable):

  • Enable the bookmark feature
  • Disable JavaScript (or load an old browser we don't support e.g. IE11)
  • Visit a page with bookmark

What happens?:
I see a blank hole where the bookmark feature is

Screenshot 2025-10-24 at 9.24.30 AM.png (2,026×356 px, 94 KB)

What should have happened instead?:
The bookmark should not show at all

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Acceptance criteria for done

  • The bookmark functionality should not show at all on articles
  • The reading lists user menu item should not show

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Load bookmark styles on non-article pages for Special:ReadingLists linkAudemediawiki/extensions/ReadingListsmaster+23 -2
styles: Hide reading list links when JS not availableJdlrobsonmediawiki/extensions/ReadingListsmaster+4 -1
Bookmark icon: Remove for browsers that do not support itLorenMoramediawiki/extensions/ReadingListsmaster+15 -0
Customize query in gerrit

Event Timeline

Jdlrobson-WMF created this task.Oct 24 2025, 4:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2025, 4:25 PM
HFan-WMF triaged this task as Medium priority.Oct 27 2025, 8:51 PM
HFan-WMF moved this task from Incoming to Needs refinement on the Reader Experience Team board.
HFan-WMF moved this task from Incoming to Graduating from Beta on the FY252627 Reading Lists board.Jun 8 2026, 8:32 PM
HFan-WMF edited projects, added: FY252627 Reading Lists (Graduating from Beta); removed: FY252627 Reading Lists.
aude raised the priority of this task from Medium to High.Aug 3 2026, 6:38 PM
aude added a project: OKR-Work.Aug 11 2026, 6:05 PM
aude set the point value for this task to 2.Mon, Aug 17, 1:57 PM
aude edited projects, added: Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]); removed: Reader Experience Team.Mon, Aug 17, 5:17 PM
LMora-WMF claimed this task.Mon, Aug 17, 7:16 PM
LMora-WMF moved this task from Ready to In progress on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.
gerritbot added a comment.Tue, Aug 18, 4:31 PM

Change #1326880 had a related patch set uploaded (by LorenMora; author: LorenMora):

[mediawiki/extensions/ReadingLists@master] Bookmark icon: Remove for browsers that do not support it

https://gerrit.wikimedia.org/r/1326880

gerritbot added a project: Patch-For-Review.Tue, Aug 18, 4:32 PM
Jdlrobson-WMF removed LMora-WMF as the assignee of this task.Tue, Aug 18, 5:39 PM
Jdlrobson-WMF moved this task from In progress to Needs QA on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.
Jdlrobson-WMF added a subscriber: LMora-WMF.
gerritbot added a comment.Tue, Aug 18, 6:04 PM

Change #1326880 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Bookmark icon: Remove for browsers that do not support it

https://gerrit.wikimedia.org/r/1326880

Maintenance_bot removed a project: Patch-For-Review.Tue, Aug 18, 6:31 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.17; 2026-08-25).Tue, Aug 18, 7:00 PM
Volker_E claimed this task.Tue, Aug 18, 8:13 PM
Volker_E added a comment.Wed, Aug 19, 2:45 AM

To be clear, the patch was fulfilling the scope of the task. It hides the bookmark icon on the articles.
It does NOT hide the saved pages Vector menu icon.

Double-checking with task author @Jdlrobson-WMF that this fulfills the task? And we might only possibly aim for a follow-up task?

Jdlrobson-WMF moved this task from Needs QA to Ready on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.EditedWed, Aug 19, 4:27 PM

Ah good catch. Since these pages don't work without JavaScript we should definitely hide #pt-readinglists-2 and #pt-readinglists as well

@LMora-WMF could we expand the scope of this ticket and could you please post a follow up?

Jdlrobson-WMF removed Volker_E as the assignee of this task.Wed, Aug 19, 8:23 PM
Jdlrobson-WMF added a subscriber: Volker_E.
Jdlrobson-WMF claimed this task.Wed, Aug 19, 8:29 PM
Jdlrobson-WMF moved this task from Ready to In progress on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.

I'll write the patch.

gerritbot added a comment.Wed, Aug 19, 9:37 PM

Change #1327200 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ReadingLists@master] Hide reading list links when JS not available

https://gerrit.wikimedia.org/r/1327200

gerritbot added a project: Patch-For-Review.Wed, Aug 19, 9:37 PM
Jdlrobson-WMF moved this task from In progress to Needs code review on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.Wed, Aug 19, 9:37 PM
Jdlrobson-WMF removed Jdlrobson-WMF as the assignee of this task.Wed, Aug 19, 10:11 PM
Volker_E updated the task description. (Show Details)Wed, Aug 19, 11:34 PM
Volker_E moved this task from Needs code review to Needs QA on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.
Volker_E removed a project: Patch-For-Review.

Reviewed, ready for QA. 👍

gerritbot added a comment.Wed, Aug 19, 11:43 PM

Change #1327200 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] styles: Hide reading list links when JS not available

https://gerrit.wikimedia.org/r/1327200

gerritbot added a comment.Thu, Aug 20, 11:09 AM

Change #1327515 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/ReadingLists@master] Load bookmark styles on non-article pages for Special:ReadingLists link

https://gerrit.wikimedia.org/r/1327515

gerritbot added a project: Patch-For-Review.Thu, Aug 20, 11:09 AM
aude subscribed.Thu, Aug 20, 11:10 AM

When I disable JS, I am still seeing the link to Special:ReadingLists on non-article pages, or things like action=watch.

Here is a patch to fix that:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReadingLists/+/1327515

aude moved this task from Needs QA to Needs code review on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.Thu, Aug 20, 11:11 AM
gerritbot added a comment.Thu, Aug 20, 3:30 PM

Change #1327515 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Load bookmark styles on non-article pages for Special:ReadingLists link

https://gerrit.wikimedia.org/r/1327515

Maintenance_bot removed a project: Patch-For-Review.Thu, Aug 20, 3:30 PM
Jdlrobson-WMF moved this task from Needs code review to Needs QA on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.Thu, Aug 20, 8:44 PM
Etonkovidova moved this task from Needs QA to Sign-off on the Reader Experience Team (REx Sprint 4 [Q1 FY26-27 Aug 11-25]) board.Fri, Aug 21, 4:50 PM
Etonkovidova subscribed.
Testing notes
  • ✅ the bookmark icon is not shown if javascript disabled

Screenshot 2026-08-21 at 12.28.37 PM.png (774×1,144 px, 110 KB)

  • the Saved pages link is present in the menu; when clicked a user sees the following warning

Screenshot 2026-08-21 at 12.46.16 PM.png (1,260×1,080 px, 150 KB)

desktopmobile
Screenshot 2026-08-21 at 12.26.57 PM.png (2,582×764 px, 143 KB)
Screenshot 2026-08-21 at 12.31.16 PM.png (758×1,260 px, 125 KB)
In T408229#12236248, @aude wrote:

When I disable JS, I am still seeing the link to Special:ReadingLists on non-article pages, or things like action=watch.

Here is a patch to fix that:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReadingLists/+/1327515

Checked on beta - all works as expected.

Jdlrobson-WMF assigned this task to HFan-WMF.Sat, Aug 22, 1:17 AM
HFan-WMF closed this task as Resolved.Mon, Aug 24, 5:54 PM
Jdlrobson-WMF reassigned this task from HFan-WMF to LMora-WMF.Mon, Aug 24, 9:46 PM
Jdlrobson-WMF added a subscriber: HFan-WMF.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits