Page MenuHomePhabricator

Review Diff lib extension for deployment
Closed, ResolvedPublic

Description

Review Diff lib extension for deployment. It can be found on Gerrit in the mediawiki/extensions/Diff project. The Diff extension acts as a library for other extensions and is used by WIkibase on both client and repository sites.


Version: master
Severity: normal

Details

Reference
bz38830

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:11 AM
bzimport set Reference to bz38830.

Assigning to Tim for now. We have some ideas of how to split the review work up a little differently, so we may change these around before reassigning.

Diff is pretty small and should be easy-ish to review. This can already be done now, as I don't expect much change to it. Also, it has over 98% test coverage :)

It currently holds two components that have been split of as commits to core, would be great if these could be reviewed first, so I can make corresponding changes in the Diff extension, and then have that reviewed.

I believe the security+architecture review that Chris did, plus all of the architecture discussions we've had, are sufficient for a deployment. Please reopen if you feel we need additional review on any of these.