avarab wrote:

Fixed in REL1_4 and HEAd, it was an invalid regular expression in
includes/Title.php that accepted redirects with the syntax #REDIRECT [[foo], the
old regular expression was \\[\\[([^\\]\\|]+)[\\]\\|] and the new one is
\[{2}(.*?)(?:\||\]{2})

rowan.collins wrote:

(In reply to comment #1)

\[{2}(.*?)(?:\||\]{2})

Won't that match unclosed piped links like "#redirect [[foo|" and "#redirect
[[foo|bar"?
I think what you want is:
\[{2}(.*?)(?:\|.*?)?\]{2}
(with a non-capturing group to eat the optional "|bar" but a compulsory "]]" at
the end)

rowan.collins wrote:

(In reply to comment #2)

\[{2}(.*?)(?:\||\]{2})

Won't that match unclosed piped links like "#redirect [[foo|" and "#redirect
[[foo|bar"?

Confirmed: see http://en.wikipedia.org/w/index.php?title=User:IMSoP/sandbox,
which contains "#REDIRECT [[User:IMSoP/Gangleri|Foo" (and
http://en.wikipedia.org/wiki/Special:Whatlinkshere/User:IMSoP/Gangleri which
fails to list this non-link, as you'd expect).

This bug is most definitely not fixed, ladies and gentlemen. I've long thought
redirect detection should be integrated into Parser.php somehow, where it could
just use the existing logic for discovering a link; at least then it would be
*consistent* (and cf bug 2333).

nicdumz wrote:

regex fix

Bug was still alive. (see http://fr.wikipedia.org/w/index.php?title=Utilisateur:NicDumZ/Test_2&redirect=no)

Included IMSoP's patch which is appropriate.

attachment 2084.diff ignored as obsolete

nicdumz wrote:

regex fix (typo)

Fixing a typo in the proposed patch.

Attached:

Fixed in r31996.