Page MenuHomePhabricator

Restrict occurrences of Wikifunctions.Debug; consider making a warning in the frontend
Open, MediumPublic

Description

Description

Calls to Wikifunctions.Debug are a bit expensive because they have to communicate over subprocess stdio. If Wikifunctions.Debug is called in a loop, it can kill performance. We should do at least one, but ideally all, of the following:

  • stop sending logs after N occurrences (i.e., just make Wikifunctions.Debug a no-op after it's been called N times);
  • send a warning in the Z22 sent from the evaluator if Wikifunctions.Debug is called more than N times;
  • add an additional warning in the UI about repeated calls to Wikifunctions.Debug (to accompany the existing warning about calling Wikifunctions.Debug at all)

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task


Completion checklist

Event Timeline

Jdforrester-WMF subscribed.

Product decision needed about which of these we want to do, at what urgency.

N=5. Let's do each of these.