Page MenuHomePhabricator

[Regression] Clicking on images after upload leads to broken links
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Upload an image using the Commons Upload Wizard
  • On the confirmation page that says "Thanks for contributing to freely available media and knowledge worldwide," click on the image, the filename below the image, or copy the URL link that is provided.

What happens?:

It goes to a page like this that is a broken link. This behavior did not used to happen.

What should have happened instead?:
Presumably the link generated should just be to the filename, not to a stash.

Other information (browser name/version, screenshots, etc.):

Upload-Wizard-Wikimedia-Commons-10-28-2025_01_11_PM.png (869×1 px, 424 KB)

Not-Found-10-28-2025_01_12_PM.png (869×1 px, 48 KB)

Event Timeline

Sdkb renamed this task from Clicking on images after upload leads to broken links to [Regression] Clicking on images after upload leads to broken links.Oct 28 2025, 5:12 PM
Sdkb added a project: UploadWizard.
Sdkb updated the task description. (Show Details)

The link target comes from the action=upload API response, .imageinfo.descriptionurl: https://gerrit.wikimedia.org/g/mediawiki/extensions/UploadWizard/+/683bba9f4f384213f3d297f12c2caff379e904dc/resources/ui/steps/uw.ui.Thanks.js#154

That in turn comes from the API code here: https://gerrit.wikimedia.org/g/mediawiki/core/+/a15c1b72fa1fae75e54d89a587c4cf4e38137a88/includes/api/ApiUpload.php#209

Looks like it checks for $upload->getStashFile() and assumes that this reflects whether the file was only uploaded to stash or actually published, but now uploads *from* stash also have this set?

Krinkle awarded a token.
Krinkle subscribed.

UploadWizard no longer has an owner listed on mw:Maintainers. Tagging two likely teams based where people went in the reorg who know where to escalate this to, while we wait for an outcome to T404286 which was raised after the reorg in July 2025.

Connnecting dots — this was also reported last week on the feedback page at Commons:Upload Wizard feedback.

Change #1199881 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ApiUpload: Fix 'imageinfo' in the response after upload from stash

https://gerrit.wikimedia.org/r/1199881

Change #1200163 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] upload: Remove stashed file in UploadFromStash when upload completed

https://gerrit.wikimedia.org/r/1200163

Change #1199881 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] ApiUpload: Fix 'imageinfo' in the response after upload from stash

Reason:

Let's go with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1200163

https://gerrit.wikimedia.org/r/1199881

Change #1200163 merged by jenkins-bot:

[mediawiki/core@master] upload: Remove stashed file in UploadFromStash when upload completed

https://gerrit.wikimedia.org/r/1200163

Change #1200191 had a related patch set uploaded (by Bartosz Dziewoński; author: Umherirrender):

[mediawiki/core@REL1_45] upload: Remove stashed file in UploadFromStash when upload completed

https://gerrit.wikimedia.org/r/1200191

Change #1200191 merged by jenkins-bot:

[mediawiki/core@REL1_45] upload: Remove stashed file in UploadFromStash when upload completed

https://gerrit.wikimedia.org/r/1200191

Change #1200194 had a related patch set uploaded (by Bartosz Dziewoński; author: Umherirrender):

[mediawiki/core@wmf/1.45.0-wmf.25] upload: Remove stashed file in UploadFromStash when upload completed

https://gerrit.wikimedia.org/r/1200194

Change #1200194 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.25] upload: Remove stashed file in UploadFromStash when upload completed

https://gerrit.wikimedia.org/r/1200194

Mentioned in SAL (#wikimedia-operations) [2025-11-03T14:35:08Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1200194|upload: Remove stashed file in UploadFromStash when upload completed (T408610)]], [[gerrit:1201064|recentchanges: Fix highlights where more than one action is defined (T409020)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-03T14:39:01Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde, matmarex: Backport for [[gerrit:1200194|upload: Remove stashed file in UploadFromStash when upload completed (T408610)]], [[gerrit:1201064|recentchanges: Fix highlights where more than one action is defined (T409020)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-11-03T14:47:18Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1200194|upload: Remove stashed file in UploadFromStash when upload completed (T408610)]], [[gerrit:1201064|recentchanges: Fix highlights where more than one action is defined (T409020)]] (duration: 12m 10s)

This is fixed on Wikimedia wikis now.