Page MenuHomePhabricator

UI Bug Bash for Image browsing (production)
Closed, ResolvedPublicBUG REPORT

Description

  • Detail view image caption is centre aligned, should be left aligned
  • Detail view caption font should be caption-text-bold, not UI-text-bold
    • Detail view caption line height should be smaller

[ ] Pages with title= in the URL don't have galleries, even when they should - can't reproduce

  • Full Screen toggle should turn off with every new image

Event Timeline

Detail view caption font should be caption-bold, not `UI-text-bold
The original spec for the caption in detail view was to have it be caption bold. We have it implemented as UI text bold.
The line height should be updated accordingly.

File (23).jpg (1×1 px, 356 KB)

Note: this was in the Figma file, but I don't think I spelled it out in the tickets, which is the source of the confusion.

Pages with title= in the URL don't have galleries, even when they should
This might be a weird parser thing. But I was getting URLs with https://en.wikipedia.org/w/index.php?title=Voyageurs&wprov=rarw1 instead of https://en.wikipedia.org/wiki/Voyageurs .
I don't know what the circumstances are that makes the URLs resolve this way, but the image browsing feature doesn't work when this happens.

File (22).jpg (1×1 px, 74 KB)

Change #1199832 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Style adjustments

https://gerrit.wikimedia.org/r/1199832

Change #1199832 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Style adjustments

https://gerrit.wikimedia.org/r/1199832

Change #1199844 had a related patch set uploaded (by Marco Fossati; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@wmf/1.45.0-wmf.25] Style adjustments

https://gerrit.wikimedia.org/r/1199844

Pages with title= in the URL don't have galleries, even when they should
This might be a weird parser thing. But I was getting URLs with https://en.wikipedia.org/w/index.php?title=Voyageurs&wprov=rarw1 instead of https://en.wikipedia.org/wiki/Voyageurs .

I can't reproduce this one: https://en.wikipedia.org/w/index.php?title=Voyageurs&wprov=rarw1&useskin=minerva&useformat=mobile&imageBrowsing=1 seems to work fine, and also other pages like
https://fr.wikipedia.org/w/index.php?title=Voyageur_(fourrure)&wprov=rarw1&imageBrowsing=1&useformat=mobile&useskin=minerva and https://vi.wikipedia.org/w/index.php?title=Sex_Pistols&wprov=rarw1&imageBrowsing=1&useformat=mobile&useskin=minerva.

Detail view image caption is centre aligned, should be left aligned
URL: https://en.wikipedia.org/wiki/Siege_of_Tunis_(Mercenary_War)?imageBrowsing=1&useskin=minerva&useformat=mobile

Detail view caption font should be caption-bold, not `UI-text-bold
The line height should be updated accordingly.

Both fixed in https://gerrit.wikimedia.org/r/c/1199832.

Change #1199844 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.45.0-wmf.25] Style adjustments

https://gerrit.wikimedia.org/r/1199844

Mentioned in SAL (#wikimedia-operations) [2025-10-30T13:13:50Z] <mfossati@deploy2002> Started scap sync-world: Backport for [[gerrit:1199814|Localisation updates from https://translatewiki.net.]], [[gerrit:1199844|Style adjustments (T408618)]], [[gerrit:1199847|Capture more captions]]

Mentioned in SAL (#wikimedia-operations) [2025-10-30T13:18:10Z] <mfossati@deploy2002> mfossati: Backport for [[gerrit:1199814|Localisation updates from https://translatewiki.net.]], [[gerrit:1199844|Style adjustments (T408618)]], [[gerrit:1199847|Capture more captions]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-30T13:36:55Z] <mfossati@deploy2002> Finished scap sync-world: Backport for [[gerrit:1199814|Localisation updates from https://translatewiki.net.]], [[gerrit:1199844|Style adjustments (T408618)]], [[gerrit:1199847|Capture more captions]] (duration: 23m 05s)

mfossati updated the task description. (Show Details)

I've verified on production, it all looks good! Closing