@HNordeenWMF Let's add the loading state details we discussed yesterday to this one. Something like (if I recall correctly):

1. While the Growth impact module API call is in progress, still show empty / blank editing modules with a centered spinner in each one.
2. If the call fails:
   1. If server responds with an error, replace spinner with an error label in the module (need mock for this).
   2. If user doesn't have an Internet connection, replace spinner with an error label in the module (need mock for this). Also present our existing "No internet connection" toast/snackbar at the top. (screenshot).

@HNordeenWMF

While the Growth impact module API call is in progress, still show empty / blank editing modules with a centered spinner in each one.
If the call fails:
If server responds with an error, replace spinner with an error label in the module (need mock for this).
If user doesn't have an Internet connection, replace spinner with an error label in the module (figma) Also present our existing "No internet connection" toast/snackbar at the top. (screenshot).

Similar question came up in engineering sync here as https://phabricator.wikimedia.org/T407676#11371640. You could see several loading spinners going at once while these fetch, which could be a bit much visually.

Do you think we could could scope cut this to a very basic single centered spinner while the editing calls are made? Then we can have a separate followup loading polish user story that can fine-tune the loading states? This way the data states can be design reviewed and QA'ed without being held up by loading state details. Let me know what you think.

Hey @Tsevener this one was a tshirt size L, but the subtasks total to 19 points. That puts it at larger than an XL,

If a user story is larger than an XL it should be broken down. If an engineering task is larger than a M it should probably be broken down.

Do you have a preference on how I break down the user story? I tried breaking out "All time impact" since that's the 2nd chunk, but I see you have the data fetching happening all at once. Let me know if this would cause confusion to break out https://phabricator.wikimedia.org/T412070

@HNordeenWMF I think if you're going to break them up, then each piece of UI should be it's own user story. That's why I designed the engineering subtasks in this way. It is all the same API endpoint so the data task can be one, but we would build each piece of UI separately.

So 5 different user stories for those. Then the fetch data task, then the loading/error state task (which I would tackle at the end once the data UI state is complete for each of these views).

I personally am ok to keep this structure as-is since we are working against engineering subtasks.

design review punchlist available here @Tsevener

to fix, post punchlist review with @Tsevener and @HNordeenWMF —

• 1- remove indent for "Most viewed since your last edit"
• 2- in "Most viewed since your edit," too large of padding between header and list items, and individual list items
• 3- view count in "Most viewed" rendering in incorrect type token, too light weight
• 4- incorrect copy in "contributions this month"
• 5- top bar in "Contributions this month" does not maintain rounded corners on the right side
• 6- (iPad) edits not rendering in contributions this month, and so "most viewed" is also not showing
• 7- contrast is off for sepia, light, and dark modes for "contributions last month"
• 8- VoiceOver not reading contents of "Most viewed edits"
• 9- VoiceOver not reading contents of "Contributions this month"
• 10- Dynamic text truncating header of "Most viewed"
• 11- Dynamic text resizing only the Symbol attached to "Most viewed" and not the others in the other modules

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5665

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/5668

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5665

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/5668

@Tsevener most of these are fixed, but i'm still seeing 2 and 3 (now looks too bold).

also, i noticed that the "Contributions this month" module is rendering the date in full (February 25, 2026) including the year:

— it should only say the month and the day of the month across the screen, for consistency, like this example from "Articles saved this month":

can this be fixed?

LGTM

Looks good to me 7.9.0 (5946). Tested on iPad Air 11-inch on iPadOS 26, and iPhone XS on iOS 26.