Maniphest T408751

Call setIsValidated after running validateAsType
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Oct 29 2025, 9:37 PM

Tags

Referenced Files

None

Subscribers

Description

Description

At the end of validateAsType, if the prospective return value does not contain an error, we should call Z1.setIsValidated( true ).

Ideally, we'd be able to use a function call count test to see a reduction in function call complexity as a result of this change.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

setIsValidated is called on validated objects
we see a reduction in function call count as a result of this change

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade orchestrator from 2025-11-04-215809 to 2025-11-08-223341	operations/deployment-charts	master	+1 -1

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	check off validation upon completion during execute	repos/abstract-wiki/wikifunctions/function-orchestrator!478	ecarg	grace/T408751/mark-setIsValidated	main

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		cmassaro	T406346 [26Q2] Orchestrator memory squashing
		Resolved		ecarg	T408751 Call setIsValidated after running validateAsType
		Resolved		cmassaro	T409379 create and add a test that counts calls to validation

Event Timeline

cmassaro created this task.Oct 29 2025, 9:37 PM

ecarg claimed this task.Oct 29 2025, 11:14 PM

ecarg added a parent task: T406346: [26Q2] Orchestrator memory squashing.Nov 2 2025, 5:48 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/478

Draft: check off validation upon completion during execute

Jdforrester-WMF changed the task status from Open to In Progress.Nov 5 2025, 6:37 PM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q2 (Oct–Dec)), OKR-Work; removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/478

check off validation upon completion during execute

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2025, 3:30 PM

Jdforrester-WMF moved this task from In Engineering to Ready to deploy on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Nov 10 2025, 1:38 PM

Change #1204583 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-11-04-215809 to 2025-11-08-223341

https://gerrit.wikimedia.org/r/1204583

gerritbot added a project: Patch-For-Review.Nov 12 2025, 1:49 PM

Change #1204583 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-11-04-215809 to 2025-11-08-223341

https://gerrit.wikimedia.org/r/1204583

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Nov 12 2025, 3:26 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 12 2025, 3:30 PM

ecarg closed this task as Resolved.Fri, Nov 14, 10:02 PM

Jdforrester-WMF closed subtask T409379: create and add a test that counts calls to validation as Resolved.Mon, Dec 8, 4:27 PM