Page MenuHomePhabricator

Drop abuse_filter_log trigger for afl_ip column
Closed, ResolvedPublic

Description

Due to the parent task T407997 replication broke on db1155 as there are triggers on abuse_filter_log table which include afl_ip column and hence need to be dropped

Fix:

stop slave; 
drop trigger if exists abuse_filter_log_update;
drop trigger if exists abuse_filter_log_insert;
CREATE DEFINER=`root`@`localhost` TRIGGER $WIKI.abuse_filter_log_insert BEFORE INSERT ON $WIKI.abuse_filter_log FOR EACH ROW SET NEW.afl_ip_hex = ''
CREATE DEFINER=`root`@`localhost` TRIGGER $WIKI.abuse_filter_log_update BEFORE UPDATE ON $WIKI.abuse_filter_log FOR EACH ROW SET NEW.afl_ip_hex = '';
start slave;

Event Timeline

Marostegui moved this task from Triage to In progress on the DBA board.

New triggers needed:

| abuse_filter_log_insert | INSERT | abuse_filter_log | SET NEW.afl_ip_hex = ''                                                                                                                                                                                                      | BEFORE | 2025-10-30 08:26:12.25 | IGNORE_BAD_TABLE_OPTIONS | root@localhost | utf8mb3              | utf8mb3_general_ci   | binary             |
| abuse_filter_log_update | UPDATE | abuse_filter_log | SET NEW.afl_ip_hex = ''                                                                                                                                                                                                      | BEFORE | 2025-10-30 08:27:15.54 | IGNORE_BAD_TABLE_OPTIONS | root@localhost | utf8mb3              | utf8mb3_general_ci   | binary             |

Fixed on s6

I will not send the puppet patch until it is all done in all sections, but I will have to fix section by section while the schema change progresses

Change #1200070 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/software@master] rebuild_abuse_filter_log_trigger.sh: Quick oneliner to drop a trigger

https://gerrit.wikimedia.org/r/1200070

Change #1200070 merged by jenkins-bot:

[operations/software@master] rebuild_abuse_filter_log_trigger.sh: Quick oneliner to drop a trigger

https://gerrit.wikimedia.org/r/1200070

Mentioned in SAL (#wikimedia-operations) [2025-11-03T06:38:32Z] <marostegui> Drop afl_ip related triggers from s2 T408780

Change #1202071 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/software@master] repl_prepare_schema.sh: Remove afl_ip

https://gerrit.wikimedia.org/r/1202071

Change #1202071 merged by jenkins-bot:

[operations/software@master] repl_prepare_schema.sh: Remove afl_ip

https://gerrit.wikimedia.org/r/1202071

Mentioned in SAL (#wikimedia-operations) [2025-11-11T16:22:37Z] <marostegui> Drop afl_ip related triggers from s4 T408780

Change #1203850 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] filtered_tables.txt: Remove afl_ip trigger

https://gerrit.wikimedia.org/r/1203850

Change #1203850 merged by Marostegui:

[operations/puppet@production] filtered_tables.txt: Remove afl_ip trigger

https://gerrit.wikimedia.org/r/1203850

Marostegui updated the task description. (Show Details)

This is all done