Page MenuHomePhabricator

Include all licenses in full text
Open, Needs TriagePublicFeature

Description

Introduction
Hey, I'm David and I'm a volunteer package maintainer for the Fedora project. I found the pywikibot quite useful (THANK YOU ❤ !) for my script to pull and compare Fedora release data (codenames, release and end of life dates) from different wikipedia pages and other web projects. It is my my little QA project to keep them all up to date and correct.

I already created a Fedora package for mwparserfromhell and pywikibot is next to have all dependencies as official distro packages. Maybe other Fedora users might find it useful to have those libraries packaged as well, who knows.

Feature summary (what you would like to be able to do and where):
The Fedora packaging guide asks me to ask you to include all the licenses used as full text as part of your source code.

Currently I only see MIT, therefore the files for CC-BY-SA 3.0, BSD, PSF and Public Domain (not sure about the last one) are missing.

Having a list of SPDX identifiers of the licenses in use would further simplify my work as downstream packager, but I'll do my best to figure those out on my own.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
Just relevant to check all the packaging guide boxes.

Benefits (why should this be implemented?):
I can't explain the rules in this case, I'm just following them. Sorry ;)

Event Timeline

Change #1207172 had a related patch set uploaded (by Dumbledore; author: Dumbledore):

[pywikibot/core@master] Add missing license files and update documentation

https://gerrit.wikimedia.org/r/1207172

Hi @Dreua

I have submitted a patch in Gerrit that addresses this task.
Feedback and review would be appreciated. Thank you!

LGTM but @Dreua do we need all license files in the root directory?

I don't think there is a rule for that so feel free to put them wherever (in the repository) you like. From my personal reasoning I'd say it should be obvious to find, for me that would be either a file (with instructions on where in the repo the further licenses are) or a directory in the root of the repository with a name like "license[s]" or "copying".

I haven't had an in depth look and comparison to my spdx identifiers yet, but on a first glance it looks very good and super helpful for downstream packagers so thank you!

Change #1207172 abandoned by Dumbledore:

[pywikibot/core@master] Add missing license files and update documentation

https://gerrit.wikimedia.org/r/1207172

Change #1212190 had a related patch set uploaded (by Dumbledore; author: Dumbledore):

[pywikibot/core@master] Add missing license files and update documentation

https://gerrit.wikimedia.org/r/1212190

Hi, I’m a new contributor and I’ve been exploring Pywikibot and its documentation.

I’d like to help with this task if it’s still available.
Please let me know if I can proceed or if there’s anything I should read first.
Thanks!