Page MenuHomePhabricator

Special:GlobalUsers doesn't normalize group names with spaces, requires underscore in URL
Closed, ResolvedPublic

Description

The URL doesn't work, the list is shown empty with "Users" selected in the dropdown; you need to use https://meta.wikimedia.org/w/index.php?title=Special:GlobalUsers&username=&group=New_wikis_importer instead (hence urlencoded URLs don't work).
Note that &username= is required because of bug 34016.


Version: master
Severity: normal
URL: https://meta.wikimedia.org/w/index.php?title=Special:GlobalUsers&username=&group=New+wikis+importer

Details

Reference
bz38883

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:47 AM
bzimport set Reference to bz38883.

This change fixes this case for WMF wikis, where all the global groups have '_' instead of spaces. But it breaks on my dev wiki where I have groups with spaces in the names.

Nemo, where was the url listed here generated?

(In reply to comment #2)

This change fixes this case for WMF wikis, where all the global groups have
'_'
instead of spaces. But it breaks on my dev wiki where I have groups with
spaces
in the names.

Then another fix should be pursued, I suppose. This works, for instance: https://meta.wikimedia.org/w/index.php?title=Special:Block/Nemo+bis

Nemo, where was the url listed here generated?

I don't remember, probably by some {{fullurl:}}'s Krinkle added to [[m:NWI]] and related.

After talking more with Hoo about it, this patch will cause the same behavior for passing in a group=group_name parameter, as we currently have for using /group_name. But, it does mean that groups with spaces can't be referenced.

Unless someone who is running CentralAuth outside of the WMF needs spaces in their group names for some reason, we'll probably merge Hoo's patch to fix it.

Merged by Siebrand on the 24th of January.