Page MenuHomePhabricator
Create Task
Maniphest T408852

PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
Open, LowPublicPRODUCTION ERROR
Actions

Description

Error
  • mwversion: 1.45.0-wmf.24
  • timestamp: 2025-10-30T18:02:47.529Z
  • phpversion: 8.3.26
  • reqId: f2af225b-b039-4c55-9775-cba2a1e5799a
  • Find reqId in Logstash
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(503)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(503)DateTime->__construct(null)
#2/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(180)GrowthExperiments\UserImpact\ComputedUserImpactLookup->getPageViewData(MediaWiki\User\User, array, array, array)
#3/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/GrowthExperimentsUserImpactUpdater.php(98)GrowthExperiments\UserImpact\ComputedUserImpactLookup->getExpensiveUserImpact(MediaWiki\User\User, int, array)
#4/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/ImpactHooks.php(43)GrowthExperiments\UserImpact\GrowthExperimentsUserImpactUpdater->refreshUserImpactData(MediaWiki\User\User)
#5/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/MWCallableUpdate.php(52)GrowthExperiments\ImpactHooks->GrowthExperiments\{closure}(string)
#6/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(445)MediaWiki\Deferred\MWCallableUpdate->doUpdate()
#7/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(187)MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\MWCallableUpdate)
#8/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(274)MediaWiki\Deferred\DeferredUpdates::run(MediaWiki\Deferred\MWCallableUpdate)
#9/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdatesScope.php(229)MediaWiki\Deferred\DeferredUpdates::MediaWiki\Deferred\{closure}(MediaWiki\Deferred\MWCallableUpdate, int)
#10/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdatesScope.php(158)MediaWiki\Deferred\DeferredUpdatesScope->processStageQueue(int, int, Closure)
#11/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(268)MediaWiki\Deferred\DeferredUpdatesScope->processUpdates(int, Closure)
#12/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(656)MediaWiki\Deferred\DeferredUpdates::doUpdates()
#13/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(478)MediaWiki\MediaWikiEntryPoint->restInPeace()
#14/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(436)MediaWiki\MediaWikiEntryPoint->doPostOutputShutdown()
#15/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(193)MediaWiki\MediaWikiEntryPoint->postOutputShutdown()
#16/srv/mediawiki/php-1.45.0-wmf.24/api.php(30)MediaWiki\MediaWikiEntryPoint->run()
#17/srv/mediawiki/w/api.php(3)require(string)
#18{main}
Impact
Notes

See T408852#11329085 - this emits a similar deprecation notice on 8.1, so this is likely not due to 8.3 unless there's an 8.3-specific behavior that would trigger the presence of null here.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
fix(Impact): skip mismatched title in pageview datamediawiki/extensions/GrowthExperimentsmaster+12 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Scott_French created this task.Oct 30 2025, 6:17 PM
Restricted Application added a project: Wikimedia-production-error. · View Herald TranscriptOct 30 2025, 6:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Scott_French added a comment.EditedOct 30 2025, 6:21 PM

Actually, even though this has only been logged (4 occurrences so far) on 8.3, this is also deprecated on 8.1. Which is to say, this may not be 8.3 migration specific, and may instead be a property of workload and / or data - all 4 instances are the same wiki (crhwiki) and enrollment in routing to 8.3 is "sticky" for a given client (cookie-based).

Scott_French updated the task description. (Show Details)Oct 30 2025, 6:24 PM
A_smart_kitten added a project: GrowthExperiments.Oct 30 2025, 7:53 PM
Krinkle removed a project: MediaWiki-Engineering.Nov 3 2025, 9:31 AM
Krinkle mentioned this in T401855: ☂ PHP 8.3 issues found during WMF rollout.Nov 3 2025, 9:33 AM
Krinkle moved this task from Backlog to Wikimedia production on the PHP 8.3 support board.
Michael moved this task from Inbox to Needs Prioritization on the Growth-Team board.Nov 6 2025, 10:23 AM
KStoller-WMF triaged this task as Medium priority.Nov 6 2025, 5:57 PM
KStoller-WMF moved this task from Needs Prioritization to Current Quarter Backlog on the Growth-Team board.
Reedy added a project: PHP 8.1 support.Nov 11 2025, 8:02 PM
Michael subscribed.Nov 12 2025, 5:30 PM

Note to self: verify that this actually still happens

Urbanecm_WMF subscribed.Nov 12 2025, 5:31 PM

I do not see this happening anymore: https://logstash.wikimedia.org/goto/c8164ad9ef59ce85340a61a266ee2dce. Maybe we can just close it as resolved by accident?

Happy to take a look if it is still happening.

thcipriani moved this task from Untriaged to Oct-Dec 2025 on the Wikimedia-production-error board.Thu, Nov 13, 4:27 PM
Michael edited projects, added GrowthExperiments-ImpactModule, Growth Team Maintenance; removed GrowthExperiments.Mon, Nov 17, 4:59 PM
Reedy lowered the priority of this task from Medium to Low.Mon, Nov 17, 11:30 PM
Reedy subscribed.

It is a bit weird when rev_timstamp is NOT NULL... So I'm guessing something didn't get loaded properly/at all, and the $title wasn't found, meaning the timestamp wasn't...

			$firstEditDate = new DateTime( $allTitleObjects[$title]['rev_timestamp'] );
			$dailyArticleViews[$title]['firstEditDate'] = $firstEditDate->format( 'Y-m-d' );
			$dailyArticleViews[$title]['newestEdit'] = $allTitleObjects[$title]['newestEdit'];
Error
  • mwversion: 1.45.0-wmf.24
  • timestamp: 2025-10-30T18:02:47.529Z
  • phpversion: 8.3.26
  • reqId: f2af225b-b039-4c55-9775-cba2a1e5799a
  • Find reqId in Logstash
normalized_message
[{reqId}] {exception_url}   PHP Warning: Undefined array key "R:Dúniya"
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(503)
#0/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(503)MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(180)GrowthExperiments\UserImpact\ComputedUserImpactLookup->getPageViewData(MediaWiki\User\User, array, array, array)
#2/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/GrowthExperimentsUserImpactUpdater.php(98)GrowthExperiments\UserImpact\ComputedUserImpactLookup->getExpensiveUserImpact(MediaWiki\User\User, int, array)
#3/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/ImpactHooks.php(43)GrowthExperiments\UserImpact\GrowthExperimentsUserImpactUpdater->refreshUserImpactData(MediaWiki\User\User)
#4/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/MWCallableUpdate.php(52)GrowthExperiments\ImpactHooks->GrowthExperiments\{closure}(string)
#5/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(445)MediaWiki\Deferred\MWCallableUpdate->doUpdate()
#6/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(187)MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\MWCallableUpdate)
#7/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(274)MediaWiki\Deferred\DeferredUpdates::run(MediaWiki\Deferred\MWCallableUpdate)
#8/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdatesScope.php(229)MediaWiki\Deferred\DeferredUpdates::MediaWiki\Deferred\{closure}(MediaWiki\Deferred\MWCallableUpdate, int)
#9/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdatesScope.php(158)MediaWiki\Deferred\DeferredUpdatesScope->processStageQueue(int, int, Closure)
#10/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(268)MediaWiki\Deferred\DeferredUpdatesScope->processUpdates(int, Closure)
#11/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(656)MediaWiki\Deferred\DeferredUpdates::doUpdates()
#12/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(478)MediaWiki\MediaWikiEntryPoint->restInPeace()
#13/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(436)MediaWiki\MediaWikiEntryPoint->doPostOutputShutdown()
#14/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(193)MediaWiki\MediaWikiEntryPoint->postOutputShutdown()
#15/srv/mediawiki/php-1.45.0-wmf.24/api.php(30)MediaWiki\MediaWikiEntryPoint->run()
#16/srv/mediawiki/w/api.php(3)require(string)
#17{main}
Impact
Notes
Error
  • mwversion: 1.45.0-wmf.24
  • timestamp: 2025-10-30T18:02:47.529Z
  • phpversion: 8.3.26
  • reqId: f2af225b-b039-4c55-9775-cba2a1e5799a
  • Find reqId in Logstash
normalized_message
[{reqId}] {exception_url}   PHP Warning: Trying to access array offset on null
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(505)
#0/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(505)MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/ComputedUserImpactLookup.php(180)GrowthExperiments\UserImpact\ComputedUserImpactLookup->getPageViewData(MediaWiki\User\User, array, array, array)
#2/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/UserImpact/GrowthExperimentsUserImpactUpdater.php(98)GrowthExperiments\UserImpact\ComputedUserImpactLookup->getExpensiveUserImpact(MediaWiki\User\User, int, array)
#3/srv/mediawiki/php-1.45.0-wmf.24/extensions/GrowthExperiments/includes/ImpactHooks.php(43)GrowthExperiments\UserImpact\GrowthExperimentsUserImpactUpdater->refreshUserImpactData(MediaWiki\User\User)
#4/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/MWCallableUpdate.php(52)GrowthExperiments\ImpactHooks->GrowthExperiments\{closure}(string)
#5/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(445)MediaWiki\Deferred\MWCallableUpdate->doUpdate()
#6/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(187)MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\MWCallableUpdate)
#7/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(274)MediaWiki\Deferred\DeferredUpdates::run(MediaWiki\Deferred\MWCallableUpdate)
#8/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdatesScope.php(229)MediaWiki\Deferred\DeferredUpdates::MediaWiki\Deferred\{closure}(MediaWiki\Deferred\MWCallableUpdate, int)
#9/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdatesScope.php(158)MediaWiki\Deferred\DeferredUpdatesScope->processStageQueue(int, int, Closure)
#10/srv/mediawiki/php-1.45.0-wmf.24/includes/deferred/DeferredUpdates.php(268)MediaWiki\Deferred\DeferredUpdatesScope->processUpdates(int, Closure)
#11/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(656)MediaWiki\Deferred\DeferredUpdates::doUpdates()
#12/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(478)MediaWiki\MediaWikiEntryPoint->restInPeace()
#13/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(436)MediaWiki\MediaWikiEntryPoint->doPostOutputShutdown()
#14/srv/mediawiki/php-1.45.0-wmf.24/includes/MediaWikiEntryPoint.php(193)MediaWiki\MediaWikiEntryPoint->postOutputShutdown()
#15/srv/mediawiki/php-1.45.0-wmf.24/api.php(30)MediaWiki\MediaWikiEntryPoint->run()
#16/srv/mediawiki/w/api.php(3)require(string)
#17{main}
Impact
Notes
Michael added a parent task: T401005: Investigate Production Errors from ComputedUserImpactLookup::getPageViewData.Fri, Nov 21, 3:01 PM

This seems to be effectively the 8.3 version of T399092/T400706. I'm looking into those now.

Michael removed a parent task: T401005: Investigate Production Errors from ComputedUserImpactLookup::getPageViewData.Fri, Nov 21, 3:09 PM
Michael added a subtask: T401005: Investigate Production Errors from ComputedUserImpactLookup::getPageViewData.
gerritbot added a comment.Fri, Nov 21, 3:48 PM

Change #1208382 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(Impact): skip mismatched title in pageview data

https://gerrit.wikimedia.org/r/1208382

gerritbot added a project: Patch-For-Review.Fri, Nov 21, 3:48 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Sat, Nov 22, 1:50 PM
gerritbot added a comment.Wed, Nov 26, 11:40 AM

Change #1208382 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(Impact): skip mismatched title in pageview data

https://gerrit.wikimedia.org/r/1208382

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Wed, Nov 26, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, Nov 26, 12:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits