Page MenuHomePhabricator
Create Task
Maniphest T408855

(Codex)TablePager's limit selector should respect default query
Open, In Progress, Needs TriagePublic
Actions

Description

The navigation bar in TablePager and CodexTablePager correctly respects getDefaultQuery, adding those parameters to each link. However, the same is not done for the limit form. So, setting a different limit will lose all the default query parameters.

Not sure if there are examples of this in beta/prod, but it can be tested with the CampaignEvents extension, with an event with over 50 associated contributions, from

http://localhost:8080/w/index.php?limit=20&title=Special%3AEventDetails%2F{EVENTID}

Where using the limit selector will lose the tab parameter that controls the view.

Screen Recording 2025-10-30 at 1.21.43 PM.gif (1×2 px, 1 MB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
limit form losing default query params in EventContributionsPagermediawiki/extensions/CampaignEventsmaster+27 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

vaughnwalters created this task.Oct 30 2025, 6:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2025, 6:31 PM
vaughnwalters added a parent task: T408256: [Epic] Collaborative contributions fix it tasks.Oct 30 2025, 6:34 PM
vaughnwalters updated the task description. (Show Details)Oct 30 2025, 6:45 PM
vaughnwalters mentioned this in T404995: Change username sorting to be alphabetic in Contributions tab.Oct 30 2025, 7:21 PM
Daimona renamed this task from Results limiter on Contributions tab should not redirect user to Event details tab to (Codex)TablePager's limit selector should respect default query.Oct 30 2025, 11:55 PM
Daimona edited projects, added MediaWiki-Special-pages; removed CampaignEvents.
Daimona updated the task description. (Show Details)
SLong-WMF subscribed.Oct 31 2025, 6:23 PM

@vaughnwalters Are there automated tests to validate navigation on this? Either UI, integration or unit tests? If we can set up data appropriately for this situation in Catalyst this would be a decent opportunity to create a test automation ticket for future work to make sure it doesn't happen again

vaughnwalters added a comment.Oct 31 2025, 6:52 PM
In T408855#11331990, @SLong-WMF wrote:

@vaughnwalters Are there automated tests to validate navigation on this? Either UI, integration or unit tests? If we can set up data appropriately for this situation in Catalyst this would be a decent opportunity to create a test automation ticket for future work to make sure it doesn't happen again

@SLong-WMF I can't speak to integration or unit tests, but there's no UI automation for this in the Campaign events extension as this is a greenfield feature and is not even released to betacluster yet. So this isn't (as far as campaign events extension goes anyway) a regression but just something that needs fixed before going live. Also why it didn't get the "bug" tag on it (or on any of the tasks in the Collaborative contributions fix it tasks epic T408256)

But as far as tests on this elsewhere outside of the extension, I am not sure if there are other examples where it might be being used elsewhere in prod. This could definitely be automated, given that we could set up a Catalyst env with the correct consistent data (which I believe will can happen, just not quite yet), though even then I am not sure that this ticket would be my top candidate for that.

ifried changed the task status from Open to In Progress.Nov 4 2025, 6:12 PM
ifried assigned this task to cmelo.
ifried edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team.
ifried moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.
cmelo moved this task from Development In Progress 💻 to Design sign-off 🖌️ on the Connection-Team (Connection-Current-Sprint) board.Nov 11 2025, 6:05 PM
cmelo moved this task from Design sign-off 🖌️ to QA / Dev input 💬 on the Connection-Team (Connection-Current-Sprint) board.

Hi @vaughnwalters, I have tested it on the maser branch, and I was not able to reproduce it anymore, I think this was fixed in some of the other tasks we did, let me know if you can still reproduce it, thank you!

Daimona subscribed.Nov 12 2025, 12:59 PM
In T408855#11364160, @cmelo wrote:

Hi @vaughnwalters, I have tested it on the maser branch, and I was not able to reproduce it anymore, I think this was fixed in some of the other tasks we did, let me know if you can still reproduce it, thank you!

Are you sure? I can still reproduce in master using the instructions in the task description. I don't think this can have been fixed without a core change.

vaughnwalters added a comment.Nov 14 2025, 12:15 PM
In T408855#11366366, @Daimona wrote:
In T408855#11364160, @cmelo wrote:

Hi @vaughnwalters, I have tested it on the maser branch, and I was not able to reproduce it anymore, I think this was fixed in some of the other tasks we did, let me know if you can still reproduce it, thank you!

Are you sure? I can still reproduce in master using the instructions in the task description. I don't think this can have been fixed without a core change.

Heya @cmelo Yes I have pulled down the latest master and am still able to reproduce

Screen Recording 2025-11-14 at 6.13.45 AM.gif (1×3 px, 1 MB)

Daimona added a comment.Nov 14 2025, 12:33 PM

Not sure if it's that, but also worth noting: use the URL in the task description to reproduce. You don't want to use a URL that already contains the tab=ContributionsPanel parameter, else it won't reproduce. You need a URL without the tab parameter.

Pppery moved this task from To triage to SpecialPage system on the MediaWiki-Special-pages board.Nov 30 2025, 4:25 PM
gerritbot added a comment.Dec 12 2025, 2:04 AM

Change #1217616 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] limit form losing default query params in EventContributionsPager

https://gerrit.wikimedia.org/r/1217616

gerritbot added a project: Patch-For-Review.Dec 12 2025, 2:04 AM
cmelo added a comment.Dec 12 2025, 2:54 AM

Thanks @vaughnwalters and @Daimona, I was able to reproduce it now, I created a patch to fix it, will move this task to code review

cmelo moved this task from QA / Dev input 💬 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Dec 12 2025, 2:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits